Invalid CloudFormation Template on initial deploy #66

oleschaper · 2017-07-07T14:34:28Z

I just tried to deploy my project with the plugin enabled but it fails with this error message:

Serverless: Packaging service...
Serverless: Preparing alias ...
Serverless: Uploading CloudFormation file to S3...
Serverless: Uploading artifacts...
Serverless: Uploading CloudFormation alias file to S3...
Serverless: Validating template...

Error --------------------------------------------------

The CloudFormation template is invalid: Template format error: Unresolved resource dependencies [ApiGatewayDeployment1499436937655] in the Resources block of the template

 For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

Stack Trace --------------------------------------------

Error: The CloudFormation template is invalid: Template format error: Unresolved resource dependencies [ApiGatewayDeployment1499436937655] in the Resources block of the template
at provider.request.catch (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/lib/validateTemplate.js:25:13)
From previous event:
at AwsDeploy.validateTemplate (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/lib/validateTemplate.js:20:12)
From previous event:
at Object.aws:deploy:deploy:validateTemplate [as hook] (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/index.js:102:10)
at BbPromise.reduce (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:233:55)
From previous event:
at PluginManager.invoke (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:233:22)
at PluginManager.spawn (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:245:17)
at AwsDeploy.BbPromise.bind.then (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/index.js:88:48)
From previous event:
at Object.deploy:deploy [as hook] (/usr/local/lib/node_modules/serverless/lib/plugins/aws/deploy/index.js:84:10)
at BbPromise.reduce (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:233:55)
From previous event:
at PluginManager.invoke (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:233:22)
at PluginManager.run (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:252:17)
at variables.populateService.then (/usr/local/lib/node_modules/serverless/lib/Serverless.js:104:33)
at runCallback (timers.js:800:20)
at tryOnImmediate (timers.js:762:5)
at processImmediate [as _immediateCallback] (timers.js:733:5)
From previous event:
at Serverless.run (/usr/local/lib/node_modules/serverless/lib/Serverless.js:91:74)
at serverless.init.then (/usr/local/lib/node_modules/serverless/bin/serverless:23:50)
at

Get Support --------------------------------------------
Docs: docs.serverless.com
Bugs: github.com/serverless/serverless/issues
Forums: forum.serverless.com
Chat: gitter.im/serverless/serverless

Your Environment Information -----------------------------
OS: darwin
Node Version: 8.1.2
Serverless Version: 1.14.0

The text was updated successfully, but these errors were encountered:

oleschaper · 2017-07-07T14:51:17Z

I don't know which template I could take a look into, I guess it is generated?
If I disable the plugin it works again.

Thank you for your help!

HyperBrain · 2017-07-08T10:55:45Z

Can you give me more information about your service configuration? The alias plugin moves the APIG deployment to a separate stack (the alias stack). Can you check if there is a reference to the APIG deployment in the cloudformation-template-update-stack.json (located in S3)?

This might be missing support for a specific feature of Serverless you use (e.g. API keys are not yet supported).

Maybe you can post your serverless.yml here, so that I can try to reproduce and fix the issue.

HyperBrain · 2017-07-08T11:30:24Z

Additionally you can use the --verbose switch, which will enable more detailed output, also for the alias plugin.

oleschaper · 2017-07-08T18:30:49Z

Hi,

your instincts are right, I am using api keys.
I removed them but now I get another error:

Serverless: Stack update finished...
Serverless: Updating alias stack...

Serverless Error ---------------------------------------

[/Resources/UserGetLambdaPermissionApiGateway/DependsOn/0] 'null' values are not allowed in templates

Stack Trace --------------------------------------------

ServerlessError: [/Resources/UserGetLambdaPermissionApiGateway/DependsOn/0] 'null' values are not allowed in templates
at Response.req.send (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:163:20)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:360:18)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at callNextListener (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:95:12)
at Request.RESET_RETRY_STATE (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/event_listeners.js:426:9)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:101:18)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:678:14)
at Request.transition (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/request.js:680:12)
at Request.callListeners (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
at callNextListener (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/sequential_executor.js:95:12)
at IncomingMessage.onEnd (/usr/local/lib/node_modules/serverless/node_modules/aws-sdk/lib/event_listeners.js:256:13)
at emitNone (events.js:110:20)
at IncomingMessage.emit (events.js:207:7)
at endReadableNT (_stream_readable.js:1047:12)
at _combinedTickCallback (internal/process/next_tick.js:102:11)
at process._tickDomainCallback (internal/process/next_tick.js:198:9)
From previous event:
at persistentRequest (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:151:14)
at doCall (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:130:9)
at BbPromise (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:141:14)
From previous event:
at persistentRequest (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:128:38)
at AwsProvider.request (/usr/local/lib/node_modules/serverless/lib/plugins/aws/provider/awsProvider.js:144:12)
at AwsAlias.updateAlias (/Users/oleschaper/dev/sviper/projects/superspellsaga/superspellsaga_backend/node_modules/serverless-aws-alias/lib/updateAliasStack.js:82:25)
at runCallback (timers.js:800:20)
at tryOnImmediate (timers.js:762:5)
at processImmediate [as _immediateCallback] (timers.js:733:5)

Get Support --------------------------------------------
Docs: docs.serverless.com
Bugs: github.com/serverless/serverless/issues
Forums: forum.serverless.com
Chat: gitter.im/serverless/serverless

Your Environment Information -----------------------------
OS: darwin
Node Version: 8.1.2
Serverless Version: 1.14.0

I checked the file cloudformation-template-update-alias-stack.json for the resource UserGetLambdaPermissionApiGateway and the DependsOn looks like this (also all the others look like this):

  "DependsOn": [
    null,
    null
  ]

If needed I could send you my serverless.yml per mail.

Thank you!

HyperBrain · 2017-07-08T18:36:49Z

That looks indeed strange. The dependency array should never ever contain null values.
Could you do come tests using my example repo (https://github.com/HyperBrain/serverless-aws-alias-example)?. A plain checkout and deploy of one of the branches should work out of the box.

You could try to configure the API within there step by step to the configuration you're actually using. There must be one step where the issue happens.

If that does not help, I'll have a look at your service definition and try to reproduce it.

oleschaper · 2017-07-08T22:50:28Z

Thank you @HyperBrain

I stripped down my serverless.yml but I can not figure out what is wrong.

cloudformation-resources.json.txt
cloudformation-template-update-alias-stack.json.txt
serverless.yml.txt

HyperBrain · 2017-07-09T08:25:13Z

@oleschaper Thank you for the files 👍 . I'll have a look and try to figure out, what exactly is missing in the plugin and if there's some edge case triggered here.

HyperBrain · 2017-07-10T10:45:21Z

It seems the error is located here:

    "UserGetLambdaPermissionApiGateway": {
      "Type": "AWS::Lambda::Permission",
      "Properties": {
        "FunctionName": {},
        "Action": "lambda:InvokeFunction",
        "Principal": "apigateway.amazonaws.com",
        "SourceArn": {
          "Fn::Join": [
            "",
            [
              "arn:aws:execute-api:",
              {
                "Ref": "AWS::Region"
              },
              ":",
              {
                "Ref": "AWS::AccountId"
              },
              ":",
              {
                "Fn::ImportValue": "MyBackend-dev-ApiGatewayRestApi"
              },
              "/*/*"
            ]
          ]
        }
      },
      "DependsOn": [
        null,
        null
      ]
    }

The permissions object is not created correctly in your case. Additionally to the null dependencies, there is also an issue with the FunctionName property which is set to an empty object here.

Honestly, I did not try the plugin with Java based code, only JavaScript/Node code. Maybe the SLS compile plugin generates something differently for Java packages. I'll try to setup a system where I can reproduce it.

In the mean-time I'll add the help-wanted tag. Maybe someone using Java can comment on the issue.

oleschaper · 2017-07-10T10:49:13Z

Thank you @HyperBrain

HyperBrain · 2017-08-17T21:33:53Z

Sorry that we did not have any feedback here since now 😢 . I'm not sure how many people use Java and the plugin or tried it. Just let's keep it some more time open.

killthrush · 2017-09-22T18:39:18Z

I'm getting the same error on a set of python 3.6 lambdas. I'm also using Gateway w/ keys. I'll try digging into this a bit more and see what I can find.

HyperBrain · 2017-09-22T18:42:57Z

Oh. it's the APIKeys. I did not add support for them yet 🤔 . Maybe I should push that and do an update release soon.

killthrush · 2017-09-22T18:44:28Z

That would be awesome - I'd be happy to test it out for you!

HyperBrain · 2017-09-23T10:23:22Z

I'll come back to you as soon as there is anything to test 😄

HyperBrain · 2017-09-28T13:00:47Z

@killthrush Can you provide me with a simple test project that uses API keys? I want to go for an implementation within the next days and it would be better to have something at hand that reflects reality.

killthrush · 2017-09-29T16:45:53Z

@HyperBrain - here you go: https://github.com/killthrush/serverless-sample

I was able to reproduce the reported error using this project. Thanks!

HyperBrain · 2017-09-29T17:14:56Z

@killthrush Thank you. I'll have some time over the weekend to take care of it and if it works well, also provide an implementation.

HyperBrain · 2017-09-30T12:22:12Z

API Key support is handled with #25 .

sambhusai · 2018-01-24T06:44:13Z

I am also getting the same issue with Java Runtime for Lambda function. I am using the ApiKeys. Removing ApiKeys, it works.

HyperBrain · 2018-01-24T10:19:31Z

Sorry for the very late reply. I was quite overloaded with my work and maintaining the webpack plugin and Serverless. The alias plugin somehow fell off the table ....

I will take care of the remaining issues now, especially API keys, DynamoDB triggers and SNS manual arns.

killthrush · 2018-01-24T14:22:15Z

Thanks! Still happy to test this out whenever there's something new to look at.

sambhusai · 2018-01-24T16:37:30Z

Thanks @HyperBrain.

eshanaka · 2018-03-26T02:52:17Z

This is what I have noticed, hopefully, it'll be useful to fix the issue.

I have noticed API-key creation and trying to associate with an HTTP endpoint can reproduce the issue. (API Key and usage plan creation and the association was working fine before enabling the aws-alias plugin)

How I define the apiKey and usage plan

apiKeys:
   - ${opt:stage}-apiKey
 usagePlan:
    throttle:
      burstLimit: 1
      rateLimit: 1

Associate with,

 - http:
            path: /functionName
            method: get
            private: true
            integration: lambda

Error  -------------
The CloudFormation template is invalid: Template format error: Unresolved resource dependencies [ApiGatewayDeployment1522032673460] in the Resources block of the template

HyperBrain · 2018-03-26T08:52:32Z

@eshanaka API Keys are still a not implemented feature (see #25 ). It would be great if someone could add support.

eshanaka · 2018-03-26T09:41:47Z

Thanks for the quick response @HyperBrain, I would really like to contribute, let me get familiar with the implementation little bit more and see how it goes.

alinefm · 2019-03-04T20:59:54Z

Any update on this?

I am having the same problem with python3.6 Lambdas and API Gateway but without API Keys.

MartinRisk · 2019-04-24T10:44:00Z

Same problem from .Net lambda's also wihout API Keys

Any update ?

HyperBrain added the help wanted label Jul 10, 2017

ColeTMNZ mentioned this issue Mar 15, 2018

serverless-domain-manager #110

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invalid CloudFormation Template on initial deploy #66

Invalid CloudFormation Template on initial deploy #66

oleschaper commented Jul 7, 2017 •

edited

Loading

oleschaper commented Jul 7, 2017

HyperBrain commented Jul 8, 2017 •

edited

Loading

HyperBrain commented Jul 8, 2017

oleschaper commented Jul 8, 2017

HyperBrain commented Jul 8, 2017

oleschaper commented Jul 8, 2017 •

edited

Loading

HyperBrain commented Jul 9, 2017

HyperBrain commented Jul 10, 2017

oleschaper commented Jul 10, 2017

HyperBrain commented Aug 17, 2017

killthrush commented Sep 22, 2017

HyperBrain commented Sep 22, 2017

killthrush commented Sep 22, 2017

HyperBrain commented Sep 23, 2017

HyperBrain commented Sep 28, 2017

killthrush commented Sep 29, 2017

HyperBrain commented Sep 29, 2017

HyperBrain commented Sep 30, 2017

sambhusai commented Jan 24, 2018

HyperBrain commented Jan 24, 2018

killthrush commented Jan 24, 2018 via email •

edited

Loading

sambhusai commented Jan 24, 2018

eshanaka commented Mar 26, 2018 •

edited

Loading

HyperBrain commented Mar 26, 2018

eshanaka commented Mar 26, 2018

alinefm commented Mar 4, 2019

MartinRisk commented Apr 24, 2019

Invalid CloudFormation Template on initial deploy #66

Invalid CloudFormation Template on initial deploy #66

Comments

oleschaper commented Jul 7, 2017 • edited Loading

oleschaper commented Jul 7, 2017

HyperBrain commented Jul 8, 2017 • edited Loading

HyperBrain commented Jul 8, 2017

oleschaper commented Jul 8, 2017

HyperBrain commented Jul 8, 2017

oleschaper commented Jul 8, 2017 • edited Loading

HyperBrain commented Jul 9, 2017

HyperBrain commented Jul 10, 2017

oleschaper commented Jul 10, 2017

HyperBrain commented Aug 17, 2017

killthrush commented Sep 22, 2017

HyperBrain commented Sep 22, 2017

killthrush commented Sep 22, 2017

HyperBrain commented Sep 23, 2017

HyperBrain commented Sep 28, 2017

killthrush commented Sep 29, 2017

HyperBrain commented Sep 29, 2017

HyperBrain commented Sep 30, 2017

sambhusai commented Jan 24, 2018

HyperBrain commented Jan 24, 2018

killthrush commented Jan 24, 2018 via email • edited Loading

sambhusai commented Jan 24, 2018

eshanaka commented Mar 26, 2018 • edited Loading

HyperBrain commented Mar 26, 2018

eshanaka commented Mar 26, 2018

alinefm commented Mar 4, 2019

MartinRisk commented Apr 24, 2019

oleschaper commented Jul 7, 2017 •

edited

Loading

HyperBrain commented Jul 8, 2017 •

edited

Loading

oleschaper commented Jul 8, 2017 •

edited

Loading

killthrush commented Jan 24, 2018 via email •

edited

Loading

eshanaka commented Mar 26, 2018 •

edited

Loading