-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No coverage information has been collected #85
Comments
edit: is the error. will look into it. |
I don't think meteor-coverage is still working, as I can see the test from the package are not working anymore :
Coverage folder has been created but no line coverage is visible. |
I'm getting a dependency version conflict with This seems to force meteortesting:mocha to downgrade to version 0.5.1, because it's the last version without an dependency on lmieulet:meteor-coverage I already created an issue: Meteor-Community-Packages/meteor-mocha#121 |
I create a PR in a few minutes, until it's published you can hotfix this in your
|
It seems to not fix the situation, I cloned and updated
and it now runs through but the generated coverage contains only empty lines! |
Downgrading to |
It would be cool if that fixes meteor-coverage tests |
@serut from my end it works with |
I assume lmieulet:[email protected] uses Meteor 1.8, whereas 4.0.0 uses the latest one. |
Hm but how can this change lead to empty coverage? Isn't it relying on Istanbul? |
Im not sure which plugin versions were selected, but with meteor 2.3.4 I'm getting this error in my CI:
|
Yes most of the job is packaged with babel / istanbul. But the remap with the sourcemap is done manually, maybe the interface changed with a newest version of node. Not sure yet Yeap, same error than tests on circle ci |
Meteor v2.3 updates node from 12.22.1 to 14.17.1 From the node release notes https://nodejs.org/en/blog/release/v14.0.0/ :
From #28666:
ERR_STREAM_WRITE_AFTER_END is related to that change. Could it be that this causes the problems? |
There is a duplicate call to
and later in
I think the second one is redundant, removing this line should fix the error from above, but I can't test it right now. |
It looks way better without this second call :
I've published lmieulet:[email protected], can you try it? The HTML report does not look functionnal, but text report OK. Let's see if the circle.ci of this package is fine too. |
Thanks this fixed my CI jobs with code coverage. HTML reports are also functional. |
I still get no coverage, it's all empty (although the files are listed). I am using
the other packages are
Any ideas? |
interesting: text summary and json summary do work fine with the above mentioned setup |
Ok so you don't have lcov and or html coverage report ? May I ask you a reproductible env ? |
@serut had no time before but the link contains a repro, although this one is even different, no coverage created at all. However, it's Meteor 2.5 and uses |
@serut any update on this? |
No time yet to work on this |
It can be broken down to the line https://github.com/serut/meteor-coverage/blob/master/server/report/report-html.js#L63 |
Downgrading to 3.2.0 fixes the issue |
it works with
|
I am also experiencing this problem. I was unable to resolve this by downgrading to 3.2.0 either. |
I am also unable to see any test results. I am testing a newly generated app and package in Meteor 2.6. The versions are the same as bessw lists above. When I run once (like for a CI), OUT_HTML and OUT_JSON both show the "Failed to save XYZ" message. OUT_TEXT "works" because there is no error, but there is no report either. |
Meteor version -> [email protected] this works for me |
"No coverage information has been collected" despite server tests passing as well as client tests passing when opening the browser, when going on localhost:3000/coverage.
i followed the guide thoroughly, adding all required packages, defining the babel env in package.json as well as setting up the proper run scripts.
Your Environment
The text was updated successfully, but these errors were encountered: