CreateEventIdProperty: consider caching EventId properties

[cd21h]

EventId is immutable class and typically is instantiated as singleton.
Caching log properties based on EventId CreateEventIdProperty may reduce memory usage.

However cache size must be limited in case EventId is generated dynamically

[nblumhardt]

Thanks for the note!

It's an interesting possibility, but there are often non-obvious performance implications of caching, so we'd first need data showing that there's a substantial allocation overhead to be saved, here, and that the caching can improve on it without other impacts.

Are you using EventId heavily in your own code, or is it mostly framework code that you think will benefit? Cheers!

[cd21h]

Hi,
sorry for delay with response.

Is is extensively used by ASP.NET Core (just an Id) and our system (both Id and Name).

[cd21h]

I run a quick test for one of my app. After running for several minutes under load I found 12K LogEventProperty objects were created / collected. Examining log file I found less than 50 unique event Ids.