Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net.Http NuGet Reference in .NET Framework 4.7.1 #77

Closed
Blackbaud-JeffDye opened this issue Dec 4, 2017 · 2 comments
Closed

Comments

@Blackbaud-JeffDye
Copy link
Contributor

Blackbaud-JeffDye commented Dec 4, 2017

Hey y'all, using this sink in a full .net framework app (even 4.7.1) seems to pull in the System.Net.Http nuget package (v4.3.2) which can cause all kinds of reference errors and assembly binding issues, along with dependencies on a few System.Security.* packages too. In this case, I think we'd rather use the actual Framework System.Net.Http.

This is similar to this issue in another sink: datalust/serilog-sinks-seq#83
Changeset which resolved that issue: https://github.com/serilog/serilog-sinks-seq/pull/85/files

Would it be possible to remove that package for Framework specifically for 4.7+?

@merbla
Copy link
Contributor

merbla commented Dec 5, 2017

@Blackbaud-JeffDye sounds reasonable, just on leave for a few weeks. Feel free to PR if you need earlier.

@jeffbdye
Copy link

jeffbdye commented Dec 5, 2017

Sounds good @merbla, I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants