listeners should not be removed on close

[pabigot]

I don't expect this to be fixed since it'd be a behavior change, but for the record:

SerialPort.prototype.close improperly removes all listeners that the application might have registered with the instance. Although the serial port can subsequently be re-opened with no difficulty and will re-use the configuration passed on construction the poor developer has to reconstruct the listeners and re-install them.

It'd probably be worth documenting that behavior.

[rwaldron]

Duplicate #638

[rwaldron]

Also, everyone hates that it does this and @reconbot and I currently have our sights set to eliminate it

[reconbot]

And also in disconnect, it shouldn't be there either

[reconbot]

And it is documented https://github.com/voodootikigod/node-serialport/blob/master/README.md#close-callback

[pabigot]

OK, I see it now. I would have seen it before if it wasn't "hidden" down inside the discussion of the callback parameter.

I am glad to see there's serious effort going towards cleaning this module up. Thanks.

[reconbot]

agreed, it's poorly documented

[reconbot]

@pabigot I made the docs a bit better around this situation

https://github.com/voodootikigod/node-serialport/blob/master/README.md#close-callback
https://github.com/voodootikigod/node-serialport/blob/master/README.md#ondisconect-callback

We'll stop doing that in a major release sometime soon.

And thank you for noticing and for being a part of it. =)