-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect is poorly defined and doesn't always work #702
Labels
Comments
This was referenced Mar 28, 2016
reconbot
changed the title
Disconnect is poorly defined
Disconnect is poorly defined and always work
May 23, 2016
@reconbot should the issue title be "Disconnect is poorly defined and doesn't always work"? |
reconbot
changed the title
Disconnect is poorly defined and always work
Disconnect is poorly defined and doesn't always work
May 23, 2016
yep =) |
Merged
We now have a single disconnect path and never remove events. I think ... I think this is closable. While there are internal cleanups to be had, the api is now documented and consistent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We call
disconnected
from all over the place, c++ bindings call it from the options. Occasionally we remove all events. Sometimes we emit the close event. It's also not documented.Having this be the discussion issue around how it currently works and how we should fix it up.
The text was updated successfully, but these errors were encountered: