Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☀️ Improve current default config management #9

Closed
sergiomartins8 opened this issue Apr 10, 2020 · 0 comments · Fixed by #13
Closed

☀️ Improve current default config management #9

sergiomartins8 opened this issue Apr 10, 2020 · 0 comments · Fixed by #13

Comments

@sergiomartins8
Copy link
Owner

sergiomartins8 commented Apr 10, 2020

Is your feature request related to a problem? Please describe.
The goal is to make it as CI/CD friendly as possible as well as easily manageable.

Describe the solution you'd like to see applied
Current configs are stored under properties files. The goal is to have default settings whilst allowing to inject the desired ones (which is currently being done, but kinda hard to understand and manage)

Describe alternatives you've considered

  1. Having a default properties file and remove de run.tests.local=true config ✅
  2. Having a static class that holds the current default properties
@sergiomartins8 sergiomartins8 self-assigned this Apr 10, 2020
@sergiomartins8 sergiomartins8 changed the title ☀️Move current file properties to system properties ☀️Improve current default config management Apr 10, 2020
@sergiomartins8 sergiomartins8 linked a pull request Apr 17, 2020 that will close this issue
2 tasks
@sergiomartins8 sergiomartins8 changed the title ☀️Improve current default config management ☀️ Improve current default config management Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant