Add support for stub modules semantics #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simplifies the callback.
tristanlatr
commented
Aug 27, 2023
Better implementation of is_typing_name().
tristanlatr
commented
Sep 20, 2023
tristanlatr
commented
Sep 20, 2023
tristanlatr
commented
Sep 21, 2023
tristanlatr
commented
Sep 21, 2023
…ineno when we need it now.
| else: | ||
| return self.orgmodule | ||
|
|
||
| _alias_needs_lineno = platform.python_implementation().lower() == 'cpython' and sys.version_info < (3,10) |
There was a problem hiding this comment.
I'd rather do _alias_needs_lineno = 'lineno' in ast.alias._attributes
There was a problem hiding this comment.
Hum, i don’t think it will work. Since the field exists but is set to None (I believe)
| @@ -290,14 +468,61 @@ class DefUseChains(ast.NodeVisitor): | |||
| One instance of DefUseChains is only suitable to analyse one AST Module in it's lifecycle. | |||
| """ | |||
|
|
|||
| def __init__(self, filename=None): | |||
| def __init__(self, | |||
There was a problem hiding this comment.
I'm stopping my review here, I think we discussed you should try to subclass beniget instead of adding a conditional path in it. Did you change your mind?
There was a problem hiding this comment.
Yes, the reason is described in the PR text. But let’s chat about it
|
Can you continue your review of these changes? |
|
Hello @serge-sans-paille, and happy new year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
I implemented some flexibility around the module name resolving and detect whether the module is a stub or a package. So isolating this new feature into a new class doesn’t really make sens. Because we’ll loose some auto detection feature that all users of beniget should enjoy having builtin.
Let me know what you think of this implementation.
I'll add more comments...