Allows yt-dlp usage as another youtube-dl fork

[Miezhiko]

Allows yt-dlp usage
https://github.com/yt-dlp/yt-dlp

[vilgotf]

How about instead of having one feature / yt-dl backend we could expose a compile-time env variable (using std::option_env!, default to youtube-dl if unset)?

[Miezhiko]

for me personally it's more handy to depend with feature, easier than making build script involving env variable for that

features = [ "yt-dlp"
           , "serenity-rustls"
           , "driver"
           , "gateway"
           ]

another possibility is to allow override/provide path to youtube-dl app in runtime instead of compile time but actually I still prefer just to specify feature, I'd mark youtube-dlc as deprecated but don't know how.

[vilgotf]

Note that build scripts for env vars won't be necessary as of 1.56 (source).

[FelixMcFelix]

I discussed this with Mawa on Discord: I think the best fix either now or later is to have a `ytdl_like` function which allows the user to also specify an executable. This is probably preferable to a feature explosion with all these forks...

…

-- Kyle

On 27 Aug 2021, at 14:44, Vilgot Fredenberg ***@***.***> wrote:  Note that build scripts for env vars won't be necessary as of 1.56 (source). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[Miezhiko]

@FelixMcFelix mawa is me, I didn't understood idea with ytdl_like function, but env variable with what @vilgotf posted in last message could be fine I think, however still possible known forks should be documented and yet I think dlc should be marked as deprecated and maybe for only one or two forks current way is okay.

[FelixMcFelix]

Apologies it's been so long to get to this. This is simple enough for now; I'm not fond of this design in the long run, so I'd like to change/deprecate it on next before long to something more generic.