Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed serenity dependency default features #18

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Fixed serenity dependency default features #18

merged 1 commit into from
Nov 23, 2020

Conversation

Maspenguin
Copy link
Contributor

This change is needed to fix this issue in serenity when using songbird.

thread 'main' panicked at 'The `framework`-feature is enabled (it's on by default), but no framework was provided.
If you don't want to use the command framework, disable default features and specify all features you want to use.'

@FelixMcFelix FelixMcFelix added the fix Fixes a bug or error label Nov 23, 2020
@FelixMcFelix
Copy link
Member

Lgtm, I hadn't tested frameworkless serenity, so this is a good catch. Thanks!

@FelixMcFelix FelixMcFelix merged commit 1ada46d into serenity-rs:current Nov 23, 2020
FelixMcFelix pushed a commit to FelixMcFelix/songbird that referenced this pull request Nov 30, 2020
@Maspenguin @FelixMcFelix
Fix: Remove serenity default features (serenity-rs#18)
8e28d18 
Allows use of songbird without serenity's framework.
@FelixMcFelix FelixMcFelix mentioned this pull request Jan 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maspenguin @FelixMcFelix @arqunis