Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tokio-tungstenite. #129

Closed
FelixMcFelix opened this issue May 23, 2022 · 4 comments
Closed

Add support for tokio-tungstenite. #129

FelixMcFelix opened this issue May 23, 2022 · 4 comments
Labels
breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes driver Relates to the driver or one of its sub-tasks. enhancement New feature or request feature-request Request for addition of a new feature or improvement.
Milestone
v0.4.0: Nightingale

Comments

@FelixMcFelix
Copy link
Member

This will prevent twilight users from compiling two separate Websocket libraries. Ideally, this should be implemented as an additive feature: having features for both backends selected should add a parameter to Config to choose this at runtime (with an arbitrary default).
@FelixMcFelix FelixMcFelix added enhancement New feature or request driver Relates to the driver or one of its sub-tasks. breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes feature-request Request for addition of a new feature or improvement. labels May 23, 2022
@FelixMcFelix FelixMcFelix added this to the v0.3.0: Nightingale milestone May 23, 2022
@nickelc
Copy link

nickelc commented Jul 4, 2022

What do you think about switching serenity and songbird to tokio-tungstenite?

@FelixMcFelix
Copy link
Member Author

That should be fine, and means we don't need to worry about all the conditional config that would come up if we supported two backends. While I'm not sure what the exact library differences are, this seems reasonable versus supporting many backends if serenity makes the switch.

@nickelc
Copy link

nickelc commented Jul 4, 2022

It's mostly just s/async_tungstenite/tokio_tungstenite/.

@nickelc nickelc mentioned this issue Jul 4, 2022
Merged
@nickelc
Copy link

nickelc commented Jul 5, 2022

Check for the required changes in serenity

FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this issue Jul 25, 2022
@FelixMcFelix
Driver: Migrate to tokio_tungstenite
cb7deb4 
This places songbird, serenity, and twilight onto the same WS library, hopefully reducing the compile overhead for everyone.

Tested using `cargo make ready` and by running `examples/voice`.

Closes serenity-rs#129.
@FelixMcFelix FelixMcFelix mentioned this issue Jul 25, 2022
Merged
FelixMcFelix added a commit that referenced this issue Jul 25, 2022
@FelixMcFelix
Driver: Migrate to tokio_tungstenite (#138)
c0e5bdd 
This places songbird, serenity, and twilight onto the same WS library, hopefully reducing the compile overhead for everyone.

Tested using `cargo make ready` and by running `examples/voice`.

Closes #129.
FelixMcFelix added a commit that referenced this issue Jul 26, 2022
@FelixMcFelix
Driver: Migrate to tokio_tungstenite (#138)
14364fb 
This places songbird, serenity, and twilight onto the same WS library, hopefully reducing the compile overhead for everyone.

Tested using `cargo make ready` and by running `examples/voice`.

Closes #129.
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this issue Nov 20, 2023
@FelixMcFelix
Driver: Migrate to tokio_tungstenite (serenity-rs#138)
76c9851 
This places songbird, serenity, and twilight onto the same WS library, hopefully reducing the compile overhead for everyone.

Tested using `cargo make ready` and by running `examples/voice`.

Closes serenity-rs#129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes driver Relates to the driver or one of its sub-tasks. enhancement New feature or request feature-request Request for addition of a new feature or improvement.
Projects
None yet
Milestone
v0.4.0: Nightingale
Development

No branches or pull requests
2 participants
@nickelc @FelixMcFelix