Skip to content

Commit

Permalink
Chore: Adapt #60, #64 in line with other breaking changes.
Browse files Browse the repository at this point in the history
This commit undoes #64 (and bumps the library MSRV accordingly), and modifies #60 to match the new `Call` connection handling.

This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
  • Loading branch information
FelixMcFelix committed May 10, 2021
1 parent 3c7f86d commit 63d53b2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 15 deletions.
7 changes: 0 additions & 7 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ version = "0.1"
optional = true
version = "1"

# TEMPORARY: remove on next breaking.
[dependencies.spinning_top]
optional = true
version = "=0.2.2"

[dependencies.streamcatcher]
optional = true
version = "0.1"
Expand Down Expand Up @@ -153,7 +148,6 @@ gateway-core = [
"flume",
"parking_lot",
"pin-project",
"spinning_top",
]
driver = [
"async-tungstenite",
Expand All @@ -177,7 +171,6 @@ driver-core = [
"rand",
"serenity-voice-model",
"spin_sleep",
"spinning_top",
"streamcatcher",
"typemap_rev",
"url",
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![docs-badge][]][docs] [![build badge]][build] [![guild-badge][]][guild] [![crates.io version]][crates.io link] [![rust 1.48.0+ badge]][rust 1.48.0+ link]
[![docs-badge][]][docs] [![build badge]][build] [![guild-badge][]][guild] [![crates.io version]][crates.io link] [![rust 1.49.0+ badge]][rust 1.49.0+ link]

# Songbird

Expand Down Expand Up @@ -69,5 +69,5 @@ Songbird's logo is based upon the copyright-free image ["Black-Capped Chickadee"
[crates.io link]: https://crates.io/crates/songbird
[crates.io version]: https://img.shields.io/crates/v/songbird.svg?style=flat-square

[rust 1.48.0+ badge]: https://img.shields.io/badge/rust-1.48.0+-93450a.svg?style=flat-square
[rust 1.48.0+ link]: https://blog.rust-lang.org/2020/11/19/Rust-1.48.html
[rust 1.49.0+ badge]: https://img.shields.io/badge/rust-1.49.0+-93450a.svg?style=flat-square
[rust 1.49.0+ link]: https://blog.rust-lang.org/2020/12/31/Rust-1.49.0.html
10 changes: 5 additions & 5 deletions src/handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,15 @@ impl Call {
}
}

/// Returns `id` of the channel, if connected to any.
/// Returns `id` of the channel, if connected or connecting to any.
///
/// **Note:**: Returned `id` is of the channel, to which bot performed connection.
/// It is possible that it is different from actual channel due to ability of server's admin to
/// move bot from channel to channel. This is to be fixed with next breaking change release.
/// This remains set after a connection failure, to allow for reconnection
/// as needed. This will change if moved into another voice channel by an
/// admin, and will be unset if kicked from a voice channel.
#[instrument(skip(self))]
pub fn current_channel(&self) -> Option<ChannelId> {
match &self.connection {
Some((id, _, _)) => Some(*id),
Some((progress, _)) => Some(progress.channel_id()),
_ => None,
}
}
Expand Down

0 comments on commit 63d53b2

Please sign in to comment.