Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

untagged enums do not support 128 bit integers #1717

Closed
Licenser opened this issue Jan 14, 2020 · 2 comments
Closed

untagged enums do not support 128 bit integers #1717

Licenser opened this issue Jan 14, 2020 · 2 comments

Comments

@Licenser
Copy link

The Content enum

serde/serde/src/private/de.rs

Line 230 in ff70409

/// Used from generated code to buffer the contents of the Deserializer when

does not include i128 or u128 fields, this makes it impossible to use those values in untagged enums.
This was referenced Jan 14, 2020
Merged
Closed
@casey casey mentioned this issue Feb 11, 2020
Closed
@mikonieminen mikonieminen mentioned this issue Jan 2, 2021
Open
@mikonieminen
Copy link

I've run into similar issues and raised a bug in serde_json: serde-rs/json#740

I've created a fork with tests showing that tagged variant works while untagged variant fails: https://github.com/mikonieminen/json/blob/128bit-bug/tests/128bit.rs

@TheJokr TheJokr mentioned this issue Jan 19, 2021
Merged
@Mingun
Copy link
Contributor

Mingun commented Aug 11, 2023

This is duplicate of #1682

@dtolnay dtolnay closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Licenser @Mingun @dtolnay @mikonieminen