Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection timeout does not work as expected #648

Open
kayabaNerve opened this issue Jan 17, 2025 · 0 comments
Open

Connection timeout does not work as expected #648

kayabaNerve opened this issue Jan 17, 2025 · 0 comments
Labels
bug Something isn't working coordinator

Comments

@kayabaNerve
Copy link
Member

.with_idle_connection_timeout(ping::INTERVAL + ping::TIMEOUT + Duration::from_secs(5))
sets the connection timeout to be a function of ping. ping explicitly will not keep a connection alive, per libp2p/rust-libp2p#4950 (comment).

We dial peers ourselves and expect the connections to be maintained ad-infinitum, unless the connections actually disconnect (which is observable by ping failing). If a validator is no longer relevant, they'll be banned. Please note this isn't entirely accurate, as we don't necessarily want to accept and maintain an unbounded amount of incoming connections, but it is the correct premise regarding dialed connections.

@kayabaNerve kayabaNerve added bug Something isn't working coordinator labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coordinator
Projects
None yet
Development

No branches or pull requests

1 participant