-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DKG re-attempts #307
Comments
Actually, instead of removing re-attempts, we may only want to trigger re-attempts on malice. Then, at end of validator set, the set publishes a full slash for the malicious validator (having only used a subset of validators the entire time). This avoids needing to model SetFailure via Substrate, instead using existing hooks. |
Removing attempts entirely has the side effect of some sets never having keys set, which breaks some code in the current InInstructions pallet. While I'm not concerned about the current pallet code, I am concerned about that implication (every set having keys) not being held. |
Closing for the reason of the last comment. |
This ended up happening with #589. |
We should never need a re-attempt. Any offline nodes, when they eventually re-connect, will realize they were supposed to participate and do so. All other nodes can simply proceed from there.
If a node maliciously participates, then the set should be destructed without that participant.
The text was updated successfully, but these errors were encountered: