Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DKG re-attempts #307

Closed
kayabaNerve opened this issue Jun 22, 2023 · 4 comments
Closed

Remove DKG re-attempts #307

kayabaNerve opened this issue Jun 22, 2023 · 4 comments
Labels
improvement This could be better

Comments

@kayabaNerve
Copy link
Member

We should never need a re-attempt. Any offline nodes, when they eventually re-connect, will realize they were supposed to participate and do so. All other nodes can simply proceed from there.

If a node maliciously participates, then the set should be destructed without that participant.

@kayabaNerve kayabaNerve added the improvement This could be better label Jun 22, 2023
@kayabaNerve
Copy link
Member Author

Actually, instead of removing re-attempts, we may only want to trigger re-attempts on malice. Then, at end of validator set, the set publishes a full slash for the malicious validator (having only used a subset of validators the entire time). This avoids needing to model SetFailure via Substrate, instead using existing hooks.

@kayabaNerve
Copy link
Member Author

Removing attempts entirely has the side effect of some sets never having keys set, which breaks some code in the current InInstructions pallet. While I'm not concerned about the current pallet code, I am concerned about that implication (every set having keys) not being held.

@kayabaNerve
Copy link
Member Author

kayabaNerve commented Aug 21, 2023

Closing for the reason of the last comment.

@kayabaNerve kayabaNerve closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@kayabaNerve
Copy link
Member Author

This ended up happening with #589.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better
Projects
None yet
Development

No branches or pull requests

1 participant