fix(model/upsert): Made the validation flag work for upserts #8872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - Check on options.validate before choosing to validate the instance in: lib/model.js
Test was checking for created === true, when sqlite returns undefined instead of true
…he id of the row it's trying to
| if (dialect === 'sqlite') { | ||
| expect(created).to.be.undefined; | ||
| } else { | ||
| expect(created).to.be.okay; |
There was a problem hiding this comment.
hmm, okay is supported too :D
sushantdhiman
approved these changes
Feb 27, 2018
janmeier
approved these changes
Feb 27, 2018
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
validateflag did nothing on model upserts meaning validations would always be run. This PR resolves this by wrapping the model validations in a condition the same way done so forModel.create