Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] use absolute paths in codecov #2496

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Mar 24, 2021

The wild coverage change is due to https://docs.codecov.io/docs/fixing-reports now working,

coverage is now not reported for lines like

{

, i.e., lines only containing a single symbol from {}().

we apparently had 614 such occurrences.
One of them was apparently a miss.
So we "lost" 613 hits and 1 miss.

All in all that means that our coverage did not decrease, because we did not gain any misses.
But from a relative POV, we had (10867 - 188) / 10867 = 0.9827 coverage before, but now only have (10254 - 187) / 10254 = 0.9817 coverage.
See also: https://docs.codecov.io/docs/coverage-offset

TLDR; the coverage dropped because our coverage code base shrunk.

@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/9cU6Hgh1Y5mFvCPqL6nYuTvLqYvC
✅ Preview: https://seqan3-git-fork-eseiler-fix-codecovactionabsolutepath-seqan.vercel.app

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #2496 (6db646e) into master (a1dd8cd) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
- Coverage   98.29%   98.20%   -0.10%     
==========================================
  Files         268      268              
  Lines       11055    10441     -614     
==========================================
- Hits        10867    10254     -613     
+ Misses        188      187       -1     
Impacted Files Coverage Δ
...an3/alignment/scoring/aminoacid_scoring_scheme.hpp 88.23% <0.00%> (-1.77%) ⬇️
...nment/pairwise/policy/simd_find_optimum_policy.hpp 79.41% <0.00%> (-1.11%) ⬇️
include/seqan3/core/detail/debug_stream_type.hpp 76.00% <0.00%> (-0.93%) ⬇️
include/seqan3/argument_parser/validators.hpp 91.39% <0.00%> (-0.91%) ⬇️
include/seqan3/utility/parallel/detail/latch.hpp 96.00% <0.00%> (-0.78%) ⬇️
.../utility/parallel/detail/reader_writer_manager.hpp 96.29% <0.00%> (-0.77%) ⬇️
...lude/seqan3/argument_parser/detail/format_html.hpp 92.40% <0.00%> (-0.70%) ⬇️
...lude/seqan3/argument_parser/detail/format_base.hpp 91.44% <0.00%> (-0.68%) ⬇️
...ignment/pairwise/detail/policy_optimum_tracker.hpp 97.29% <0.00%> (-0.53%) ⬇️
...lude/seqan3/argument_parser/detail/format_help.hpp 88.69% <0.00%> (-0.52%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1dd8cd...6db646e. Read the comment docs.

@eseiler eseiler force-pushed the fix/codecov_action_absolute_path branch from def976c to 262f8bb Compare March 24, 2021 18:00
@eseiler eseiler force-pushed the fix/codecov_action_absolute_path branch from 262f8bb to 6db646e Compare March 24, 2021 18:55
@eseiler eseiler force-pushed the fix/codecov_action_absolute_path branch from 45d1808 to 6db646e Compare March 24, 2021 21:07
@eseiler eseiler requested review from a team and eaasna and removed request for a team March 24, 2021 21:07
@eseiler eseiler marked this pull request as ready for review March 24, 2021 21:07
Copy link
Contributor

@eaasna eaasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@eaasna eaasna requested review from a team and marehr and removed request for a team March 26, 2021 08:19
@marehr marehr merged commit 06961d3 into seqan:master Mar 29, 2021
@eseiler eseiler deleted the fix/codecov_action_absolute_path branch May 14, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants