Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate seqan3::views::move #328

Closed
3 tasks
marehr opened this issue Apr 18, 2021 · 0 comments · Fixed by seqan/seqan3#2563
Closed
3 tasks

deprecate seqan3::views::move #328

marehr opened this issue Apr 18, 2021 · 0 comments · Fixed by seqan/seqan3#2563
Assignees

Comments

@marehr
Copy link
Member

marehr commented Apr 18, 2021

Tasks

  • deprecate seqan3::views::move
  • remove usage from our tests/snippets
  • add changelog entry
From 1b48bb91b43870d7be376a98700785553aa97322 Mon Sep 17 00:00:00 2001
From: marehr <[email protected]>
Date: Sun, 18 Apr 2021 12:47:49 +0200
Subject: [PATCH 06/35] TODO: [MISC] deprecate seqan3::views::move

---
 include/seqan3/range/views/move.hpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/seqan3/range/views/move.hpp b/include/seqan3/range/views/move.hpp
index 84832b859..79508353d 100644
--- a/include/seqan3/range/views/move.hpp
+++ b/include/seqan3/range/views/move.hpp
@@ -66,6 +66,8 @@ namespace seqan3::views
  *
  * A more useful example can be found in \link sequence_file_section_fun_with_ranges the tutorial \endlink.
  * \hideinitializer
+ * \deprecated Use the std::ranges::move algorithm, std::cpp20::move_iterator or an explicit for loop where you move
+ *             the value.
  */
 inline auto const move = std::views::transform(detail::multi_invocable
 {
-- 
2.31.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant