Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear() for the interleaved_bloom_filter #296

Closed
eseiler opened this issue Mar 4, 2021 · 0 comments · Fixed by seqan/seqan3#2428
Closed

clear() for the interleaved_bloom_filter #296

eseiler opened this issue Mar 4, 2021 · 0 comments · Fixed by seqan/seqan3#2428

Comments

@eseiler
Copy link
Member

eseiler commented Mar 4, 2021

Description

We need a clear functionality to reset individual bins.
Old code: https://github.com/eseiler/seqan/blob/d8b3fcd55858c150bc1dd95fa3cf4c8ebb640829/include/seqan/binning_directory/binning_directory_interleaved_bloom_filter.h#L219

Interface could look like:

// ... 
// ibf is an seqan3::interleaved_bloom_filter

ibf.clear(seqan3::bin_index{5u}); // clear a single bin
ibf.clear(std::vector{seqan3::bin_index{2u}, seqan3::bin_index{30u}}); // clear a range

// Maybe:
ibf.clear(); // clear IBF

clear() is only callable on uncompressed IBF (similar to emplace).
The range overload would follow the idea that we want to add a range overload to emplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant