Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alignment] Deprecate seqan3::gap_scheme #283

Closed
4 tasks done
smehringer opened this issue Jan 18, 2021 · 2 comments
Closed
4 tasks done

[Alignment] Deprecate seqan3::gap_scheme #283

smehringer opened this issue Jan 18, 2021 · 2 comments
Assignees
@SGSSGene

Comments

@smehringer
Copy link
Member

smehringer commented Jan 18, 2021 •
edited by SGSSGene
Loading

Description

Discussed in #268

The gap scheme is not needed anymore since we handle the configuration of gap costs differently

  • Add SEQAN3_DEPRECATED_310 macro to the seqan3::gap_scheme class

was done already but the documentation does not show it.

Tasks

  • Add [DEPREACTED] in front of the brief message of seqan3::gap_scheme
  • Add the \deprecated doxygen tag to the class brief
  • Check any mentions in the tutorials and remove them
@smehringer smehringer mentioned this issue Jan 18, 2021
Closed
@SGSSGene SGSSGene self-assigned this Feb 14, 2021
@SGSSGene
Copy link

Open: Is the complete gap_scheme.hpp file with all the other structs also deprecated?

@marehr
Copy link
Member

marehr commented Mar 15, 2021

@SGSSGene Can this be closed? Did you check the tutorials? ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SGSSGene SGSSGene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marehr @SGSSGene @smehringer