Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move C++20 things into std namespace #134

Closed
2 tasks done
marehr opened this issue Mar 24, 2020 · 3 comments · Fixed by seqan/seqan3#2079
Closed
2 tasks done

Move C++20 things into std namespace #134

marehr opened this issue Mar 24, 2020 · 3 comments · Fixed by seqan/seqan3#2079
Assignees
Labels
good first issue Good for newcomers

Comments

@marehr
Copy link
Member

marehr commented Mar 24, 2020

In Core Meeting (2020-03-23) we decided that stuff that will be part of C++20 and that we implement in seqan3 already should be defined in the std namespace and included via the respective header.

This means

Take seqan/seqan3#1681 as a basis, but don't put remove_cvref_t in seqan3::cpp20, but directly in the std namespace.

?? I find no more examples that are c++20, but defined in seqan3; Some standard concepts ??

@simonsasse simonsasse self-assigned this Jun 2, 2020
@svnbgnk svnbgnk self-assigned this Jun 2, 2020
@simonsasse simonsasse removed their assignment Jun 4, 2020
@marehr marehr transferred this issue from seqan/seqan3 Jun 13, 2020
@marehr marehr assigned marehr and unassigned svnbgnk Aug 11, 2020
@marehr marehr added the good first issue Good for newcomers label Aug 17, 2020
@marehr
Copy link
Member Author

marehr commented Aug 17, 2020

@wvandertoorn, @simonsasse Are you interested in finishing this ticket?

@marehr marehr closed this as completed Aug 17, 2020
@marehr marehr reopened this Aug 17, 2020
@wvdtoorn
Copy link

Yes, I'll work on this

@marehr
Copy link
Member Author

marehr commented Oct 14, 2020

Fixed by seqan/seqan3#2079

@marehr marehr closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants