[FIX] Fix EnumValidator #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseiler
approved these changes
Mar 20, 2021
Irallia
commented
Mar 22, 2021
test/cli/iGenVar_cli_test.cpp
Outdated
Comment on lines
294
to
289
| { | ||
| "[Error] Value parse failed for -m: Argument 9 could not be parsed as type std::string.\n" | ||
| }; |
There was a problem hiding this comment.
This unhelpful error message is fixed by issue seqan/seqan3#2464.
…s) can be used and give a nice help page view. Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
FIX/fix_EnumValidator
branch
from
3488bf5 to
02b1949
Compare
Irallia
force-pushed
the
FIX/fix_EnumValidator
branch
from
02b1949 to
04253ce
Compare
eldariont
requested changes
Apr 7, 2021
| { | ||
| cli_test_result result = execute_app("iGenVar"); | ||
| std::string expected | ||
| std::string expected_res |
There was a problem hiding this comment.
This local variable has the same name as the global variable above. Maybe rename to expected_res_no_options?
There was a problem hiding this comment.
Or we move the global variable into the test cases which use it? I guess we could decide to either define all result and error messages above the test cases or inside each test case. A mix of both is confusing.
Signed-off-by: Lydia Buntrock <[email protected]>
Signed-off-by: Lydia Buntrock <[email protected]>
Irallia
force-pushed
the
FIX/fix_EnumValidator
branch
from
1b56376 to
1c9d468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78
Update EnumValidator such that
args.methods(detection_methods) can be used and give a nice help page view.EDIT (22.03.2021): We should probably wait for seqan/seqan3#2464 and update the seqan3 library.
EDIT (06.04.2021): We also want to wait for seqan/seqan3#2502 to avoid another seqan3 version change.
EDIT (07.04.2021): Both seqan PRs are merged now. This PR can get merged after the reviews.