Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part.met files carving #1636

Merged
merged 10 commits into from
May 9, 2023
Merged

Conversation

hugohmk
Copy link
Contributor

@hugohmk hugohmk commented Apr 14, 2023

Header and footer signature added for part.met files.

Also closes #1677 an closes #1678.

Header and footer signature added for part.met files
@lfcnassif
Copy link
Member

Thanks @hugohmk!

Have you tested if this causes performance degradation? I'm concerned about the single E0 byte in the header, since it is alone, it is searched for alone and may cause tons of intermediate false positives. Later the results are combined with those found with the last 4 bytes sequence in the header, checking if their distance is the number of ? chars. Not sure if the slow down will be significant or not.

@hugohmk
Copy link
Contributor Author

hugohmk commented Apr 14, 2023

I'll run some tests to see if there is noticeable performance loss... Also, I'll try to compare it with another possible solution (carving through KnownMetCarveTask), and then share my findings once it's done.

@lfcnassif
Copy link
Member

Great, thank you!

Updated KnownMetCarveTask to also work with part.met files
@lfcnassif
Copy link
Member

Just a quick suggestion, maybe replacing the first 0xE0 byte in header by ? may be enough to avoid performance issues and, together with the footer, avoid false positives...

Avoid skipping large offsets
@hugohmk
Copy link
Contributor Author

hugohmk commented Apr 25, 2023

After some testing, it seems that the best solution would be to carve part.met files alongside known.met files in KnownMetCarveTask. This change sould not impact the task's performance that much.

Copy link
Member

@lfcnassif lfcnassif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugohmk. @tc-wleite I've pushed some small fixes, please let me know if they are not ok, thanks.

@lfcnassif lfcnassif merged commit 8be06cd into sepinf-inc:master May 9, 2023
@hugohmk hugohmk deleted the Part.met-carving branch May 9, 2023 23:22
lfcnassif added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants