-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part.met files carving #1636
Part.met files carving #1636
Conversation
Header and footer signature added for part.met files
Thanks @hugohmk! Have you tested if this causes performance degradation? I'm concerned about the single E0 byte in the header, since it is alone, it is searched for alone and may cause tons of intermediate false positives. Later the results are combined with those found with the last 4 bytes sequence in the header, checking if their distance is the number of ? chars. Not sure if the slow down will be significant or not. |
I'll run some tests to see if there is noticeable performance loss... Also, I'll try to compare it with another possible solution (carving through KnownMetCarveTask), and then share my findings once it's done. |
Great, thank you! |
Updated KnownMetCarveTask to also work with part.met files
This reverts commit fd71d9f.
Just a quick suggestion, maybe replacing the first 0xE0 byte in header by ? may be enough to avoid performance issues and, together with the footer, avoid false positives... |
Avoid skipping large offsets
After some testing, it seems that the best solution would be to carve part.met files alongside known.met files in KnownMetCarveTask. This change sould not impact the task's performance that much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hugohmk. @tc-wleite I've pushed some small fixes, please let me know if they are not ok, thanks.
Header and footer signature added for part.met files.
Also closes #1677 an closes #1678.