Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data/Config Upload to IPFS #164

Merged
merged 9 commits into from
Nov 22, 2022
Merged

Data/Config Upload to IPFS #164

merged 9 commits into from
Nov 22, 2022

Conversation

sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

#145 and #144

What does this implement/fix? Explain your changes.

Added
  • get_data function
  • get_config function
Changed
  • upload_data parameter added to nft_storage method
  • upload_config parameter added to nft_storage method

Any other comments?

@sadrasabouri sadrasabouri requested review from sepandhaghighi and removed request for sepandhaghighi November 14, 2022 10:45
"metadata": {},
"outputs": [],
"source": [
"g.nft_storage(api_key=\"YOUR_API_KEY\", upload_config=True)"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g1 instead of g

@sadrasabouri
Copy link
Collaborator Author

@sepandhaghighi can you please review it again? I fixed the problems.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #164 (4bf7b23) into dev (b8967ac) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          553       572   +19     
  Branches        82        88    +6     
=========================================
+ Hits           553       572   +19     
Impacted Files Coverage Δ
samila/functions.py 100.00% <100.00%> (ø)
samila/genimage.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sadrasabouri
Copy link
Collaborator Author

@sepandhaghighi I believe now it's ready. 🚀

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sepandhaghighi sepandhaghighi merged commit f21f82c into dev Nov 22, 2022
@sepandhaghighi sepandhaghighi deleted the data-config2ipfs branch November 22, 2022 09:32
@sadrasabouri sadrasabouri mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants