Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation #176

Closed
sadrasabouri opened this issue Jan 24, 2023 · 0 comments · Fixed by #187
Closed

Rotation #176

sadrasabouri opened this issue Jan 24, 2023 · 0 comments · Fixed by #187
Assignees
@sadrasabouri
Labels
enhancement New feature or request
Milestone
samila v1.1

Comments

@sadrasabouri
Copy link
Collaborator

Description

In some cases, we need to rotate pictures yielding more exciting images.

Steps/Code to Reproduce

g = GenerativeImage()
g.generate()
g.plot(rotation=45)

Expected Behavior

Return a rotated version of the picture, something like the below:
rotated

Actual Behavior

Since we do not have rotation parameter it will raise an error, anyway, we should have something like the below image as our original image:
original

Samila Version (Use : samila.__version__)

1.0
@sadrasabouri sadrasabouri added the enhancement New feature or request label Jan 24, 2023
@sadrasabouri sadrasabouri added this to the samila v1.1 milestone Jan 24, 2023
@sadrasabouri sadrasabouri self-assigned this Jan 24, 2023
sadrasabouri added a commit that referenced this issue Feb 9, 2023
@sadrasabouri
test : tests added (#176)
1eb6b51
@sadrasabouri sadrasabouri mentioned this issue Feb 9, 2023
Merged
sepandhaghighi added a commit that referenced this issue Mar 26, 2023
@sadrasabouri @sepandhaghighi
Rotation Added (#177)
a54a510 
* rotate : [INIT]

* edit : docstring edited.

* add : `rotate` function added.

* edit : docstring edited.

* add : `rotate` added to config and data files.

* log : changes logged.

* update : document updated.

* test : tests added (#176)

* add : `PIL` added to dependecies.

* fix : typo fixed in `requirements.txt`.

* remove : extra import in `genimage.py` removed.

* add : version for Pillow.

---------

Co-authored-by: sepandhaghighi <[email protected]>
@sepandhaghighi sepandhaghighi mentioned this issue Apr 3, 2023
Merged
@sepandhaghighi sepandhaghighi linked a pull request Apr 3, 2023 that will close this issue
Version 1.1 #187
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadrasabouri sadrasabouri

Labels
enhancement New feature or request
Projects
None yet
Milestone
samila v1.1
Development

Successfully merging a pull request may close this issue.

Version 1.1 sepandhaghighi/samila
2 participants
@sepandhaghighi @sadrasabouri