Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init sentinel dashboard operator #1

Merged
merged 10 commits into from
Nov 30, 2022
Merged

Conversation

garroshh
Copy link
Contributor

@garroshh garroshh commented Nov 18, 2022

需求分析

sentinel dashboard 支持 kubernetes 原生部署

场景分析

我们希望提交给kubernetes一份sentinel资源,kubernetes 帮我们自动生成相应的deployment和service, 生产级场景,可能还要生成ingress,pv,pvc等,而不用再手动去写相应的kubernetes原生多个资源。

apiVersion: sentinelguard.io/v1alpha1
kind: Sentinel
metadata:
  name: sentinel-dashboard
  namespace: sentinel-group
spec:
  replicas: 1
  image: "sentinel-group/sentinel-dashboard:v0.1.0"
  type: "NodePort"
  ports:
  - port: 8080
    nodePort: 30000
  env:
  - name: "NACOS_ADDRESS"
    value: "nacos.nacos-group:8848"
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1
      memory: 1Gi
status:
  phase: "running"

功能需求(todo)

  1. status 字段

    如 运行节点ip,运行正常状态等

  2. 日志部分PV,PVC local strorage Spec 部分

    如 dashboard 业务日志及metrics日志存储等

  3. helm charts 部署

  4. k8事件记录

  5. operator 高可用配置

  6. 集群流控

  7. 是否启用ingress对外暴露

非功能需求

暂无

@wilsonwu
Copy link
Contributor

@sczyh30 please help to review

@wilsonwu
Copy link
Contributor

@garroshh please change all daocloud.io to sentinelguard.io

@wilsonwu
Copy link
Contributor

/lgtm
@sczyh30 ptal

@sczyh30
Copy link
Member

sczyh30 commented Nov 18, 2022

cc @sentinel-group/sentinel-committers for review

@sczyh30
Copy link
Member

sczyh30 commented Nov 18, 2022

Could you please add some description of your design and implementation in the PR description?

@sczyh30
Copy link
Member

sczyh30 commented Nov 18, 2022

For reviewers: original issue: alibaba/Sentinel#2952

@sczyh30 sczyh30 requested a review from a team November 21, 2022 05:50
@sczyh30 sczyh30 added the kind/feature Category issues or PRs related to feature request. label Nov 21, 2022
@wilsonwu
Copy link
Contributor

/lgtm again.

@wilsonwu
Copy link
Contributor

Is there any progress we can follow and speed up the PR process?
@sczyh30 @sentinel-group/sentinel-committers

@samzong
Copy link

samzong commented Nov 23, 2022

+1 look good.

README.md Outdated Show resolved Hide resolved
@wilsonwu
Copy link
Contributor

Any improvement we need to do? @sczyh30

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 7e9a823 into sentinel-group:main Nov 30, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 30, 2022

Nice work. Thanks for contributing and look forward to more! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or PRs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants