You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Audit the code base to see if we need changes elsewhere
Thinking about the issue, I realized we may need to do much more than just 1. because the issue is not catched at compile time. The Go 1.15 change leads to a panic at runtime. The panic in 1. was catched by tests, but there may be other places that suffer from the same problem, that are not triggered by testing!
Context
I came across failing test cases while running tests on my machine that were passing on CI and other people's machines. We narrowed it down to a change in Go 1.15.
A thought just popped up in my head: I mentioned here that maybe we can alleviate the issue by checking if a context is nil before calling functions like context.WithValue() and replace it with context.Background() if that's the case.
But surely, if it was that simple, that's how the Go team would have gone about fixing it in the context library? Why didn't they do that? Let's be careful with the approach I suggest...
We are currently "stuck" with Go 1.13 because it depends on #3729.
Once we are done with the etcd upgrade, updating Go to 1.15 or later will require some work because of the following behaviour:
When running tests with Go 1.15, the following failure is exhibited:
This is because of a change introduced in Go 1.15.
Feature Suggestion
Do whatever is necessary do be able to move forward with Go 1.15 and later versions.
Possible Implementation
backend/api/graphql
I've left a few notes here to achieve that.
Thinking about the issue, I realized we may need to do much more than just 1. because the issue is not catched at compile time. The Go 1.15 change leads to a panic at runtime. The panic in 1. was catched by tests, but there may be other places that suffer from the same problem, that are not triggered by testing!
Context
I came across failing test cases while running tests on my machine that were passing on CI and other people's machines. We narrowed it down to a change in Go 1.15.
The text was updated successfully, but these errors were encountered: