Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require conformance to style standards #632

Closed
thinkingserious opened this issue Oct 4, 2018 · 3 comments
Closed

Require conformance to style standards #632

thinkingserious opened this issue Oct 4, 2018 · 3 comments
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

In the CONTRIBUTING.md file there is a section on Style Guidelines & Naming Conventions. Please review and implement a check in Travis CI. If there are any style errors, either fix or create a rule to exclude the error.

Before writing any code, we suggest you review our CONTRIBUTING.md file and propose your solution for discussion here in the comments. Thank you!

Aceptance Criteria

  • TravisCI checks that the code conforms to our Style Guidelines & Naming Conventions as defined in our CONTRIBUTING.md file
  • tests pass locally, in Travis CI and using Docker
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Oct 4, 2018
@mosesmeirelles
Copy link

mosesmeirelles commented Oct 4, 2018

Hi, I would like to take this up 😄

[edit] Just opened PR, anything please contact me (This is my first OS contribution ever btw 😄 )

@vipulgupta2048
Copy link

Hello @thinkingserious, reading the issue made by you makes me think we need a solution to this kind sendgrid/python-http-client#66 and could be implemented quite easily with the travis builds. I would love to write the code for it.

@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

4 participants