Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar issue in CHANGELOG #778

Merged
merged 4 commits into from
Jul 20, 2020
Merged

docs: fix grammar issue in CHANGELOG #778

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5964707
Update CHANGELOG.md
Hestersue43 Oct 31, 2018
a99bcc4
Update DynamicTemplateTest.php
Hestersue43 Oct 31, 2018
0e8dccf
Merge branch 'master' into master
Jul 20, 2020
bfd6993
Update DynamicTemplateTest.php
Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ Thanks to the [strong support and feedback of the SendGrid PHP community](https:

In particular, I'd like to make special mention of [@caseyw](https://github.com/caseyw), [@vitya1](https://github.com/vitya1), [@Braunson](https://github.com/Braunson), [@cbschuld](https://github.com/cbschuld), [@paoga87](https://github.com/paoga87), [@Taluu](https://github.com/Taluu), [@mazanax](https://github.com/mazanax), [@ninsuo](https://github.com/ninsuo), [@ianh2](https://github.com/ianh2), [@WadeShuler](https://github.com/WadeShuler), [@jaimehing](https://github.com/jaimehing), [@KnightAR](https://github.com/KnightAR), [@alextech](https://github.com/alextech) (my apologies if I've missed you)

Since this is a major departure from v6.X, we advise you refactor your code according to the documentation found in the [README](https://github.com/sendgrid/sendgrid-php/blob/master/README.md) and [USE_CASES](https://github.com/sendgrid/sendgrid-php/blob/master/USE_CASES.md) files. We hope you find the new interface much easier to work with. Please open an [issue](https://github.com/sendgrid/sendgrid-php/issues) or PR if you run into any trouble or have any feedback.
Since this is a major departure from v6.X, we advise you to refactor your code according to the documentation found in the [README](https://github.com/sendgrid/sendgrid-php/blob/master/README.md) and [USE_CASES](https://github.com/sendgrid/sendgrid-php/blob/master/USE_CASES.md) files. We hope you find the new interface much easier to work with. Please open an [issue](https://github.com/sendgrid/sendgrid-php/issues) or PR if you run into any trouble or have any feedback.

If you wish to continue using previous versions of this SDK, no problem. However, we will not be updating versions less than v7 except for critical bugs and/or security issues.

Expand Down
8 changes: 4 additions & 4 deletions test/unit/DynamicTemplateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ class DynamicTemplateTest extends BaseTestClass
},
{
"type": "text/calendar",
"value": "Party Time!!"
"value": "Party Time!"
},
{
"type": "text/calendar2",
"value": "Party Time 2!!"
"value": "Party Time 2!"
}
],
"from": {
Expand Down Expand Up @@ -115,11 +115,11 @@ class DynamicTemplateTest extends BaseTestClass
},
{
"type": "text/calendar",
"value": "Party Time!!"
"value": "Party Time!"
},
{
"type": "text/calendar2",
"value": "Party Time 2!!"
"value": "Party Time 2!"
}
],
"from": {
Expand Down