Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sample env file #520 #523

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Added sample env file #520 #523

merged 2 commits into from
Oct 29, 2017

Conversation

yeoji
Copy link
Contributor

@yeoji yeoji commented Oct 27, 2017

Added a sample env file to include the SENDGRID_API_KEY.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 27, 2017

CLA assistant check
All committers have signed the CLA.

README.md Outdated
echo "export SENDGRID_API_KEY='YOUR_API_KEY'" > sendgrid.env
echo "sendgrid.env" >> .gitignore
source ./sendgrid.env
cp .env_sample .env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it .env.sample.

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link

Well done, thank you!

@mbernier mbernier merged commit d04707c into sendgrid:master Oct 29, 2017
@thinkingserious
Copy link
Contributor

Hello @yeoji,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@yeoji yeoji deleted the sampleenv branch October 29, 2017 10:10
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants