Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Data residency for eu and global region #1104

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Adding data residency with global as the default region and adding support for eu region as well.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tiwarishubham635
Copy link
Contributor Author

The checks are failing as of now since the php-http-client PR is not merged due to which setHost is not working.

@tiwarishubham635
Copy link
Contributor Author

tiwarishubham635 commented Nov 21, 2023

The php-http-client PR is merged, however it is not released. That's why when make test-docker is run, the docker container is not able to pick the merged changes. I am attaching screenshots of the local environment where I manually made changes and the tests are passing.

Output of make test

Screenshot 2023-11-21 at 11 45 43 AM

Output of running the test fie - DataResidencyTest.php

Screenshot 2023-11-21 at 11 46 24 AM

Copy link

@tbischel tbischel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably in all the examples should note that to use the EU region, their subuser must be pinned. One thing I'm wondering is if we should link to the docs for how subuser pinning will work. These do not exist yet publicly, so we may want a followup round to add a link to the documentation in example comments next quarter.

@tbischel
Copy link

There do seem to be a lot of failing checks...

@shrutiburman
Copy link

We probably in all the examples should note that to use the EU region, their subuser must be pinned. One thing I'm wondering is if we should link to the docs for how subuser pinning will work. These do not exist yet publicly, so we may want a followup round to add a link to the documentation in example comments next quarter.

Makes sense, I can create a ticket to add the documentation link in all SDKs, when its available publicly.

@tiwarishubham635 tiwarishubham635 merged commit cfe19cc into main Nov 30, 2023
1 of 9 checks passed
@tiwarishubham635 tiwarishubham635 deleted the set_data_residency branch November 30, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants