Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set from email incorrect error message #987

Closed
oleddzo opened this issue Jul 2, 2020 · 3 comments · Fixed by #762
Closed

Set from email incorrect error message #987

oleddzo opened this issue Jul 2, 2020 · 3 comments · Fixed by #762
Labels
type: bug bug in the library

Comments

@oleddzo
Copy link

oleddzo commented Jul 2, 2020

Hello, I've found an issue, when I set incorrect email to FROM get an error '$email must be valid and of type string.', but $email in the string should be a value that I try to set. I figured out why it happened, in this function SendGrid\Mail\Mail::setFrom you should replace single-quotes to double-quotes in the error message. Thank you.

@childish-sambino
Copy link
Contributor

Nice find. Working on a fix ...

@childish-sambino childish-sambino added status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library labels Jul 2, 2020
@kampalex
Copy link
Contributor

kampalex commented Jul 2, 2020

Similar to issue #841.
Fixing the $email in the string should be a value that I try to set may be simple, but this only works if an invalid string is provided. Also mentioned during review.

I think a more durable solution is needed like already contributed #762.

@childish-sambino
Copy link
Contributor

@kampalex Good call. Slowly working through old PRs but Octobers get crazy. I'll probably fix up that PR to resolve this issue.

@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug bug in the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants