Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails because of API breaking of google/go-github #267

Closed
nightvisi0n opened this issue Feb 21, 2017 · 5 comments
Closed

Build fails because of API breaking of google/go-github #267

nightvisi0n opened this issue Feb 21, 2017 · 5 comments
Labels

Comments

@nightvisi0n
Copy link
Contributor

Currently the build of semaphore fails with the following error:

--> linux/amd64 error: exit status 2                                                                                   
Stderr: # github.com/ansible-semaphore/semaphore/util                                                                  
../util/upgrade.go:99: not enough arguments in call to gh.Repositories.ListReleases

This is because the used go lib google/go-github broke their API with a recent commit to master:
google/go-github@23d6cb9

@nightvisi0n
Copy link
Contributor Author

google/go-github#526

@nightvisi0n
Copy link
Contributor Author

@matejkramny I'm working on a PR fixing this partly..

@matejkramny
Copy link
Contributor

Ok 👍

A more permanent solution is using a system like glide

@nightvisi0n
Copy link
Contributor Author

Yeah that seems to be a good long-term solution 🙂

@matejkramny
Copy link
Contributor

I'm happy to accept PR for either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants