Replace webpack with Rollup #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-zhukov
commented
Aug 20, 2017
| "test": "jest", | ||
| "docs": "docsify init ./docs", | ||
| "lint": "node files/lint", | ||
| "dev": "jest __tests__/tap", | ||
| "node-build": "webpack --config files/webpack.config.node.js", | ||
| "browser-build": "webpack --config files/webpack.config.js", | ||
| "all-build": "rollup -c files/rollup.config.js", |
There was a problem hiding this comment.
Not happy with the name "all-build", do you have something better in mind?
There was a problem hiding this comment.
There is also an option to move it into "build" and drop npm-run-all dep
vlad-zhukov
commented
Aug 20, 2017
| format: 'cjs', | ||
| exports: 'named', | ||
| interop: false, | ||
| sourceMap: false, |
There was a problem hiding this comment.
I disabled source maps since they are not generated currently, but I believe they should be enabled because they provide a better development experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial work on #27
Features:
Bundle sizes:
Webpack:
index.js 29621
webVersion.js 12834
Rollup:
index.js 21922
index.esm.js 20547
webVersion.js 12195