BitbucketOrganizations uses a deprecated API endpoint

[alilosoft]

@amihaiemil While working on #984 I noticed some issues, I think 🤓

self-core/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketOrganizations.java

Line 60 in 36dbcb4

this.uri = URI.create(bitbucketUriStr + slash + "teams");

First, the endpoint /teams is deprecated, which should be replaced by /workspaces if it meets our needs, see doc

Second, if we decided to stick with /teams endpoint, than we should fix another issue, because that endpoint need a mandatory query parameter role which is not provided in the current impl:

self-core/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketOrganizations.java

Lines 67 to 68 in 36dbcb4

	public Iterator<Organization> iterator() {
	final Resource resource = this.resources.get(this.uri);

Another issue, is the reposUri got from json will contain /!api/ which will not work for authenticated requests.

self-core/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketOrganization.java

Lines 65 to 70 in 36dbcb4

	public Repos repos() {
	final URI reposUri = URI.create(this.json
	.get("links").asJsonObject()
	.get("repositories").asJsonObject()
	.getString("href"));
	return new BitbucketOrganizationRepos(reposUri,

And a question :)
Why BitbucketOrganizationRepos impl, overrides two default methods from Iteratable?

self-core/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketOrganizationRepos.java

Lines 65 to 73 in 36dbcb4

	@Override
	public void forEach(final Consumer<? super Repo> action) {
	throw new UnsupportedOperationException("Not implemented yet");
	}
	@Override
	public Spliterator<Repo> spliterator() {
	throw new UnsupportedOperationException("Not implemented yet");
	}

[zoeself]

@fellahi-ali thank you for reporting this. I'll assign someone to take care of it soon.

[zoeself]

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

[amihaiemil]

@fellahi-ali (cc: @criske) thanks for this ticket. I recently started working with BitBucket for a new client and yes, I also noticed the Bitbucket works with workspaces.

BUT from what I noticed so far (maybe I'm wrong), the workspaces are NOT the equivalent of Organizations. For instance my BitBucket account now has 2 workspaces: 1 is the personal workspace with my personal repositories and 1 is the workspace of the Organization where my client's repository is.

So, I think workspaces are just an intermediary concept of BitBucket which we should ignore. But again, I'm not sure.

The last point with overriding the default methods of Iterable is definetely a mistake, we only implement iterator, that's it.

Let's leave this ticket open for now, it contains valuable information. We will come back to it a bit later.

[amihaiemil]

@zoeself remove

[zoeself]

@zoeself remove

@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore.

[criske]

@amihaiemil Actually the "real" organization is a much more complex thing, though Bitbucket as product is not integrated yet (hence these major api changes and deprecations)

https://support.atlassian.com/organization-administration/docs/what-is-an-atlassian-organization/

But for the Self scope, I think is ok to asume that workspace is equivalent-ish with github's org, imo :D.