Skip to content

Commit

Permalink
Remove the apache-backed httpclient
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon Stewart committed Sep 26, 2018
1 parent a0a7d82 commit f671fd2
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 666 deletions.
3 changes: 0 additions & 3 deletions java/client/src/org/openqa/selenium/remote/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ java_library(name = 'remote-lib',
'http/JsonHttpResponseCodec.java',
'http/W3CHttpCommandCodec.java',
'http/W3CHttpResponseCodec.java',
'internal/ApacheHttpClient.java',
'internal/HttpClientFactory.java',
'internal/HttpUrlBuilder.java',
'internal/OkHttpClient.java',
'internal/JsonToWebElementConverter.java',
Expand All @@ -137,7 +135,6 @@ java_library(name = 'remote-lib',
':capabilities',
'//java/client/src/org/openqa/selenium/json:json',
'//java/client/src/org/openqa/selenium/remote/session:session',
'//third_party/java/httpcomponents:httpclient',
'//third_party/java/okhttp3:okhttp',
],
deps = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

import org.openqa.selenium.BuildInfo;
import org.openqa.selenium.Platform;
import org.openqa.selenium.remote.internal.ApacheHttpClient;
import org.openqa.selenium.remote.internal.OkHttpClient;

import java.io.IOException;
Expand Down Expand Up @@ -63,9 +62,6 @@ interface Factory {
static Factory createDefault() {
String defaultFactory = System.getProperty("webdriver.http.factory", "okhttp");
switch (defaultFactory) {
case "apache":
return new ApacheHttpClient.Factory();

case "okhttp":
default:
return new OkHttpClient.Factory();
Expand Down

This file was deleted.

Loading

1 comment on commit f671fd2

@diemol
Copy link
Member

@diemol diemol commented on f671fd2 Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of deletions on this commit is a bit scary...

Please sign in to comment.