Prevent a resource leak in the display help handler

SeleniumHQ · Oct 23, 2018 · c1b3853 · c1b3853
1 parent 50f263c
commit c1b3853
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/java/server/src/org/openqa/grid/web/servlet/DisplayHelpHandler.java b/java/server/src/org/openqa/grid/web/servlet/DisplayHelpHandler.java
@@ -99,9 +99,10 @@ public void execute(HttpRequest req, HttpResponse resp) throws IOException {
 
           final String json = jsonBuilder.toString();
 
-          final String htmlTemplate =
-              new BufferedReader(new InputStreamReader(in, UTF_8)).lines()
-                  .collect(Collectors.joining("\n"));
+          final String htmlTemplate;
+          try (BufferedReader reader = new BufferedReader(new InputStreamReader(in, UTF_8))) {
+              htmlTemplate = reader.lines().collect(Collectors.joining("\n"));
+          }
           final String updatedTemplate =
               htmlTemplate.replace(HELPER_SERVLET_TEMPLATE_CONFIG_JSON_VAR, json);
           if (resource.equals("/")) {