[JS] Fix: making methods static (#11182)

SeleniumHQ · Nov 1, 2022 · 472eebb · 472eebb
1 parent 3bdde2a
commit 472eebb
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 21 deletions.
diff --git a/javascript/node/selenium-webdriver/lib/virtual_authenticator.js b/javascript/node/selenium-webdriver/lib/virtual_authenticator.js
@@ -169,24 +169,34 @@ class Credential {
    * @param userHandle userHandle associated to the credential. Must be Base64 encoded string.
    * @param privateKey Base64 encoded PKCS
    * @param signCount initial value for a signature counter.
+   * @deprecated This method has been made static. Call it with class name. Example, Credential.createResidentCredential()
    * @returns A resident credential
    */
   createResidentCredential(id, rpId, userHandle, privateKey, signCount) {
     return new Credential(id, true, rpId, userHandle, privateKey, signCount)
   }
 
+  static createResidentCredential(id, rpId, userHandle, privateKey, signCount) {
+    return new Credential(id, true, rpId, userHandle, privateKey, signCount)
+  }
+
   /**
    * Creates a non-resident (i.e. stateless) credential.
    * @param id Unique base64 encoded string.
    * @param rpId Relying party identifier.
    * @param privateKey Base64 encoded PKCS
    * @param signCount initial value for a signature counter.
+   * @deprecated This method has been made static. Call it with class name. Example, Credential.createNonResidentCredential()
    * @returns A non-resident credential
    */
   createNonResidentCredential(id, rpId, privateKey, signCount) {
     return new Credential(id, false, rpId, null, privateKey, signCount)
   }
 
+  static createNonResidentCredential(id, rpId, privateKey, signCount) {
+    return new Credential(id, false, rpId, null, privateKey, signCount)
+  }
+
   toDict() {
     let credentialData = {
       credentialId: Buffer.from(this._id).toString('base64url'),

diff --git a/javascript/node/selenium-webdriver/test/lib/credentials_test.js b/javascript/node/selenium-webdriver/test/lib/credentials_test.js
@@ -51,14 +51,13 @@ describe('Credentials', function () {
 
   it('can testRkEnabledCredential', function () {
     const { _id, rpId, userHandle, privateKey, signCount } = data
-    const credential =
-      new virtualAuthenticatorCredential().createResidentCredential(
-        _id,
-        rpId,
-        userHandle,
-        privateKey,
-        signCount
-      )
+    const credential = virtualAuthenticatorCredential.createResidentCredential(
+      _id,
+      rpId,
+      userHandle,
+      privateKey,
+      signCount
+    )
 
     let testCredentialId = new Uint8Array([1, 2, 3, 4])
 
@@ -105,7 +104,7 @@ describe('Credentials', function () {
   it('can testRkDisabledCredential', function () {
     const { _id, rpId, privateKey, signCount } = data
     const credential =
-      new virtualAuthenticatorCredential().createNonResidentCredential(
+      virtualAuthenticatorCredential.createNonResidentCredential(
         _id,
         rpId,
         privateKey,
@@ -141,14 +140,13 @@ describe('Credentials', function () {
 
   it('can testToDict', function () {
     const { _id, rpId, userHandle, privateKey, signCount } = data
-    const credential =
-      new virtualAuthenticatorCredential().createResidentCredential(
-        _id,
-        rpId,
-        userHandle,
-        privateKey,
-        signCount
-      )
+    const credential = virtualAuthenticatorCredential.createResidentCredential(
+      _id,
+      rpId,
+      userHandle,
+      privateKey,
+      signCount
+    )
 
     let credential_dict = credential.toDict()
     assert.equal(

diff --git a/javascript/node/selenium-webdriver/test/virtualAuthenticator_test.js b/javascript/node/selenium-webdriver/test/virtualAuthenticator_test.js
@@ -190,7 +190,7 @@ suite(function (env) {
          */
         driver = await createRkDisabledCTAP2Authenticator(driver)
         let credential =
-          new virtualAuthenticatorCredential().createNonResidentCredential(
+          virtualAuthenticatorCredential.createNonResidentCredential(
             new Uint8Array([1, 2, 3, 4]),
             'localhost',
             Buffer.from(BASE64_ENCODED_PK, 'base64').toString('binary'),
@@ -223,7 +223,7 @@ suite(function (env) {
           'RmgsJYxGP__fWN_S-j5sN4tT15XEpN_7QZnt14YvI6uvAgO0uJEboFaZlOEB'
 
         let credential =
-          new virtualAuthenticatorCredential().createNonResidentCredential(
+          virtualAuthenticatorCredential.createNonResidentCredential(
             new Uint8Array([1, 2, 3, 4]),
             'localhost',
             Buffer.from(base64EncodedPK, 'base64').toString('binary'),
@@ -248,7 +248,7 @@ suite(function (env) {
         driver = await createRkEnabledCTAP2Authenticator(driver)
 
         let credential =
-          new virtualAuthenticatorCredential().createResidentCredential(
+          virtualAuthenticatorCredential.createResidentCredential(
             new Uint8Array([1, 2, 3, 4]),
             'localhost',
             new Uint8Array([1]),
@@ -286,7 +286,7 @@ suite(function (env) {
           'RmgsJYxGP__fWN_S-j5sN4tT15XEpN_7QZnt14YvI6uvAgO0uJEboFaZlOEB'
 
         let credential =
-          new virtualAuthenticatorCredential().createResidentCredential(
+          virtualAuthenticatorCredential.createResidentCredential(
             new Uint8Array([1, 2, 3, 4]),
             'localhost',
             new Uint8Array([1]),