[java] Add JUnit5 support for BiDiLogTest

SeleniumHQ · Jun 22, 2022 · 0c7bf07 · 0c7bf07
1 parent 3e993df
commit 0c7bf07
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/java/test/org/openqa/selenium/bidi/log/BUILD.bazel b/java/test/org/openqa/selenium/bidi/log/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@rules_jvm_external//:defs.bzl", "artifact")
-load("//java:defs.bzl", "java_library", "java_selenium_test_suite")
+load("//java:defs.bzl", "JUNIT5_DEPS", "java_selenium_test_suite")
 
 java_selenium_test_suite(
     name = "large-tests",
@@ -22,10 +22,9 @@ java_selenium_test_suite(
         "//java/test/org/openqa/selenium/testing:annotations",
         "//java/test/org/openqa/selenium/testing:test-base",
         "//java/test/org/openqa/selenium/testing/drivers",
-
         artifact("com.google.guava:guava"),
-        artifact("junit:junit"),
+        artifact("org.junit.jupiter:junit-jupiter-api"),
         artifact("org.assertj:assertj-core"),
         artifact("org.hamcrest:hamcrest"),
-    ],
+    ] + JUNIT5_DEPS,
 )
diff --git a/java/test/org/openqa/selenium/bidi/log/BiDiLogTest.java b/java/test/org/openqa/selenium/bidi/log/BiDiLogTest.java
@@ -17,9 +17,9 @@
 
 package org.openqa.selenium.bidi.log;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.bidi.BiDi;
 import org.openqa.selenium.environment.webserver.AppServer;
@@ -41,7 +41,7 @@ public class BiDiLogTest {
   private AppServer server;
   private FirefoxDriver driver;
 
-  @Before
+  @BeforeEach
   public void setUp() {
     FirefoxOptions options = new FirefoxOptions();
     options.setCapability("webSocketUrl", true);
@@ -128,7 +128,7 @@ public void canRetrieveStacktraceForALog()
     }
   }
 
-  @After
+  @AfterEach
   public void quitDriver() {
     if (driver != null) {
       driver.quit();