[grid] Adding method to know if driver supports BiDi

SeleniumHQ · Oct 13, 2022 · 07d52d4 · 07d52d4
1 parent 73b0d80
commit 07d52d4
Show file tree

Hide file tree

Showing 9 changed files with 45 additions and 0 deletions.
diff --git a/java/src/org/openqa/selenium/WebDriverInfo.java b/java/src/org/openqa/selenium/WebDriverInfo.java
@@ -55,6 +55,11 @@ public interface WebDriverInfo {
    */
   boolean isSupportingCdp();
 
+  /**
+   * @return Whether the driver has enabled the CDP interface.
+   */
+  boolean isSupportingBiDi();
+
   /**
    * Often, a {@link WebDriver} instance needs one or more supporting files or executables to be
    * present (such as a vendor-provided executable which speaks the WebDriver Protocol). This means

diff --git a/java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java b/java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
@@ -56,6 +56,11 @@ public boolean isSupportingCdp() {
     return true;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/src/org/openqa/selenium/edge/EdgeDriverInfo.java b/java/src/org/openqa/selenium/edge/EdgeDriverInfo.java
@@ -57,6 +57,11 @@ public boolean isSupportingCdp() {
     return true;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/src/org/openqa/selenium/firefox/GeckoDriverInfo.java b/java/src/org/openqa/selenium/firefox/GeckoDriverInfo.java
@@ -66,6 +66,11 @@ public boolean isSupportingCdp() {
     return true;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return true;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java b/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java
@@ -549,6 +549,11 @@ public boolean isSupportingCdp() {
         return detectedDriver.isSupportingCdp();
       }
 
+      @Override
+      public boolean isSupportingBiDi() {
+        return  detectedDriver.isSupportingBiDi();
+      }
+
       @Override
       public boolean isAvailable() {
         return detectedDriver.isAvailable();

diff --git a/java/src/org/openqa/selenium/ie/InternetExplorerDriverInfo.java b/java/src/org/openqa/selenium/ie/InternetExplorerDriverInfo.java
@@ -54,6 +54,11 @@ public boolean isSupportingCdp() {
     return false;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/src/org/openqa/selenium/safari/SafariDriverInfo.java b/java/src/org/openqa/selenium/safari/SafariDriverInfo.java
@@ -61,6 +61,11 @@ public boolean isSupportingCdp() {
     return false;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/src/org/openqa/selenium/safari/SafariTechPreviewDriverInfo.java b/java/src/org/openqa/selenium/safari/SafariTechPreviewDriverInfo.java
@@ -62,6 +62,11 @@ public boolean isSupportingCdp() {
     return false;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     try {

diff --git a/java/test/org/openqa/selenium/remote/FakeWebDriverInfo.java b/java/test/org/openqa/selenium/remote/FakeWebDriverInfo.java
@@ -53,6 +53,11 @@ public boolean isSupportingCdp() {
     return true;
   }
 
+  @Override
+  public boolean isSupportingBiDi() {
+    return false;
+  }
+
   @Override
   public boolean isAvailable() {
     return true;