[ci] Update workflow for secrets inherit

Signed-off-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Dec 25, 2024 · d4ed4ef · d4ed4ef
1 parent c91807b
commit d4ed4ef
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
@@ -2,6 +2,11 @@ name: Build & test
 
 on:
   workflow_call:
+    secrets:
+      DOCKER_USERNAME:
+        required: false
+      DOCKER_PASSWORD:
+        required: false
     inputs:
       release:
         description: 'Test a new release process'
@@ -41,7 +46,7 @@ env:
 jobs:
   docker-test:
     if: contains(toJson(github.event.commits), '[skip test]') == false
-    name: Test Seleium Grid on Docker
+    name: Test Selenium Grid on Docker
     uses: ./.github/workflows/docker-test.yml
     with:
       release: ${{ inputs.release == 'true' }}

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -37,6 +37,7 @@ jobs:
     name: Build and Test
     if: contains(toJson(github.event.commits), '[deploy]') == true || (github.event_name == 'workflow_dispatch' && github.event.inputs.skip-test == 'false')
     uses: ./.github/workflows/build-test.yml
+    secrets: inherit
     with:
       release: ${{ github.event.inputs.stable || true }}
 

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -15,6 +15,7 @@ jobs:
     name: Build and Test Nightly
     if: github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.event.inputs.skip-test == 'false')
     uses: ./.github/workflows/build-test.yml
+    secrets: inherit
     with:
       release: false
 

diff --git a/charts/selenium-grid/CONFIGURATION.md b/charts/selenium-grid/CONFIGURATION.md
@@ -162,7 +162,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
 | loggingConfigMap.nameOverride | string | `nil` | Override the name of the logging configMap |
 | loggingConfigMap.annotations | object | `{}` | Custom annotations for configmap |
 | serverConfigMap.nameOverride | string | `nil` | Override the name of the server configMap |
-| serverConfigMap.env | object | `{"SE_JAVA_OPTS":"-Djdk.httpclient.keepalive.timeout=300 -Djdk.httpclient.maxstreams=10000 -XX:+UseZGC","SE_SUPERVISORD_LOG_LEVEL":"info"}` | Extra common environment variables for Server (https://www.selenium.dev/documentation/grid/configuration/cli_options/#server) to server configMap |
+| serverConfigMap.env | object | `{"SE_JAVA_OPTS":"-XX:+UseG1GC -Xmx1024m -Xms256m -XX:MaxGCPauseMillis=1000 -Djdk.httpclient.keepalive.timeout=300 -Djdk.httpclient.maxstreams=10000","SE_SUPERVISORD_LOG_LEVEL":"info"}` | Extra common environment variables for Server (https://www.selenium.dev/documentation/grid/configuration/cli_options/#server) to server configMap |
 | serverConfigMap.annotations | object | `{}` | Custom annotations for configmap |
 | secrets.create | bool | `true` | Create the default secret for all components. If using an external secret, set to false and provide its name in `nameOverride` below |
 | secrets.nameOverride | string | `nil` | Override to use an external secret |