Skip to content

Commit

Permalink
Update a notice for Chrome --headless=new and xvfb enable
Browse files Browse the repository at this point in the history
Fixes: #2436

Signed-off-by: Viet Nguyen Duc <[email protected]>
  • Loading branch information
VietND96 committed Oct 24, 2024
1 parent 42a7ecd commit 7491764
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ workflows:
name: "K8s test - Autoscaling Deployments - HTTPS"
platforms: linux/arm64
machine-type: ubuntu2204arm64large
k8s-version: 'v1.31.1'
k8s-version: 'v1.31.2'
test-strategy: deployment_https
cluster: 'minikube'
helm-version: 'v3.16.1'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/helm-chart-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
docker-version: '26.1.4'
test-upgrade: true
service-mesh: false
- k8s-version: 'v1.31.1'
- k8s-version: 'v1.31.2'
test-strategy: deployment_https
cluster: 'minikube'
helm-version: 'v3.16.1'
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ SBOM_OUTPUT := $(or $(SBOM_OUTPUT),$(SBOM_OUTPUT),package_versions.txt)
KEDA_TAG_PREV_VERSION := $(or $(KEDA_TAG_PREV_VERSION),$(KEDA_TAG_PREV_VERSION),2.15.1-selenium-grid)
KEDA_TAG_VERSION := $(or $(KEDA_TAG_VERSION),$(KEDA_TAG_VERSION),2.15.1-selenium-grid)
KEDA_BASED_NAME := $(or $(KEDA_BASED_NAME),$(KEDA_BASED_NAME),ndviet)
KEDA_BASED_TAG := $(or $(KEDA_BASED_TAG),$(KEDA_BASED_TAG),2.15.1-selenium-grid-20241007)
KEDA_BASED_TAG := $(or $(KEDA_BASED_TAG),$(KEDA_BASED_TAG),2.15.1-selenium-grid-20241017)

all: hub \
distributor \
Expand Down
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1183,8 +1183,8 @@ captured in the same video.

### Running in Headless mode

[Firefox](https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Headless_mode),
[Chrome](https://developers.google.com/web/updates/2017/04/headless-chrome),
[Firefox](https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Headless_mode),
[Chrome](https://developer.chrome.com/docs/chromium/headless),
When using headless mode, there's no need for the [Xvfb](https://en.wikipedia.org/wiki/Xvfb) server to be started.

To avoid starting the server you can set the `SE_START_XVFB` environment variable to `false`
Expand All @@ -1197,6 +1197,9 @@ $ docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub -e SE_EVENT_BUS_PUB

For more information, see this GitHub [issue](https://github.com/SeleniumHQ/docker-selenium/issues/567).

Noted:
- In new Chrome/Chromium versions (v127+), `SE_START_XVFB` is required to be set to `true` to run in `--headless=new` mode.

### Stopping the Node/Standalone after N sessions have been executed

In some environments, like Docker Swarm or Kubernetes, it is useful to shut down the Node or Standalone
Expand Down

0 comments on commit 7491764

Please sign in to comment.