Skip to content

Commit

Permalink
fix(chart: Use empty strings as defaults for some empty values (#2176)
Browse files Browse the repository at this point in the history
- Installing a chart containing selenium-grid chart as a dependency, values are nil: the block above produces empty output, looks like it performs no iterations
- Installing a chart containing selenium-grid chart as a dependency, values are "": correct output
  • Loading branch information
maxmanuylov authored Mar 29, 2024
1 parent e1c4f17 commit 6a6d1e1
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions charts/selenium-grid/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ nodeConfigMap:
# Directory where the extra scripts are mounted to
extraScriptsDirectory: "/opt/selenium"
extraScripts:
nodePreStop.sh:
nodeProbe.sh:
nodePreStop.sh: ""
nodeProbe.sh: ""
# Name of volume mount is used to mount scripts in the ConfigMap
scriptVolumeMountName:
# Automatic browser leftovers cleanup stuck browser processes, tmp files
Expand All @@ -136,8 +136,8 @@ recorderConfigMap:
extraScriptsDirectory: "/opt/bin"
# List of extra scripts to be mounted to the container. Format as `filename: content`
extraScripts:
# video.sh:
# video_graphQLQuery.sh:
# video.sh: ""
# video_graphQLQuery.sh: ""
# Name of volume mount is used to mount scripts in the ConfigMap
scriptVolumeMountName:
videoVolumeMountName: videos
Expand All @@ -154,7 +154,7 @@ uploaderConfigMap:
extraScriptsDirectory: "/opt/bin"
# List of extra scripts to be mounted to the container. Format as `filename: content`
extraScripts:
upload.sh:
upload.sh: ""
# Extra files stored in Secret to be mounted to the container.
secretFiles:
upload.conf: "[sample]"
Expand Down

0 comments on commit 6a6d1e1

Please sign in to comment.