You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw two problems that can be eliminated very easily.
Based on bower.json specification please see the highlighted text below: Only one file per filetype.
Do not include minified files.
"main": [
"dist/select2-bootstrap.css",
"dist/select2-bootstrap.min.css"
],
So these two rules are ignored in this case, but the best solution would be declaration of scss file as entry-point in order to be consistent with Select2 core. This is very important when you use with nodejs something like main-bower-files or wiredep .
Also it is very important to add !default flag to all variables under select2-bootstrap.scss file.
The text was updated successfully, but these errors were encountered:
Yes and yes! Thanks for reporting those @kalidema, ... I keep forgetting both. :/
I will make sure these will land in the next release. Help out with a pull request if you have the time, please - if you are shying away because of the Less version I can take care of that.
I saw two problems that can be eliminated very easily.
Only one file per filetype.
Do not include minified files.
"main": [
"dist/select2-bootstrap.css",
"dist/select2-bootstrap.min.css"
],
So these two rules are ignored in this case, but the best solution would be declaration of scss file as entry-point in order to be consistent with Select2 core. This is very important when you use with nodejs something like main-bower-files or wiredep .
The text was updated successfully, but these errors were encountered: