Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two problems that can be eliminated very easily #44

Closed
kalidema opened this issue Jun 25, 2016 · 2 comments
Closed

Two problems that can be eliminated very easily #44

kalidema opened this issue Jun 25, 2016 · 2 comments

Comments

@kalidema
Copy link
Contributor

kalidema commented Jun 25, 2016

I saw two problems that can be eliminated very easily.

  1. Based on bower.json specification please see the highlighted text below:
    Only one file per filetype.
    Do not include minified files.

    "main": [
    "dist/select2-bootstrap.css",
    "dist/select2-bootstrap.min.css"
    ],
    So these two rules are ignored in this case, but the best solution would be declaration of scss file as entry-point in order to be consistent with Select2 core. This is very important when you use with nodejs something like main-bower-files or wiredep .
  2. Also it is very important to add !default flag to all variables under select2-bootstrap.scss file.
@fk
Copy link
Member

fk commented Jun 26, 2016

Yes and yes! Thanks for reporting those @kalidema, ... I keep forgetting both. :/

I will make sure these will land in the next release. Help out with a pull request if you have the time, please - if you are shying away because of the Less version I can take care of that.

@fk
Copy link
Member

fk commented Jun 29, 2016

@kalidema Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants