Skip to content
This repository has been archived by the owner on Oct 5, 2019. It is now read-only.

Clicking on the slider line (VS dragging handles) doesn't invoke change of UI using change event #80

Open
crmn111 opened this issue Jul 13, 2015 · 3 comments

Comments

@crmn111
Copy link

crmn111 commented Jul 13, 2015

UI and model are out of sync using the change event, because change event is not invoked on the UI, only the model is adapted.
I can see the reason why this is done, because following the bootstrap slider documentation and implementing 'change/onchange' event handler, it generates a warning.

I have resolved this locally by renaming the change event handler onchangeslide.

Now when you click on the slider line (VS dragging the slider handles), which is a common thing to do for a user, both the model and view are updated, as expected.

I will make a pull request for this, also i will change the readme to accommodate the event handlers, if you don't mind?

Which notation of event handlers is preferred? on 'onslide' or 'on-slide' ?

@crmn111
Copy link
Author

crmn111 commented Jul 13, 2015

it's strange but when i fork this repo i get different code than when i do bower install angular-bootstrap-slider but the version numbers seem to be the same (both 1.3.0)

@seiyria
Copy link
Owner

seiyria commented Jul 13, 2015

That's because I don't do a git tag that often. See here for event preferences.

@evillemez
Copy link
Contributor

@dirkjan111 Any news on a PR? I think what you're describing might be the source of the problem in #71 ... maybe?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants