Consume gas before verifying range proof #1987
Merged
+77
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/confidentialtransfers/module.go
Outdated
Comment on lines
183
to
186
| go func() { | ||
| ch <- am.ExportGenesis(ctx, cdc) | ||
| close(ch) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
dssei
reviewed
Dec 11, 2024
dssei
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Consuming gas only after performing all operations could lead to exploits where a lot of work is done but no gas is consumed (or gas provided is insufficient). The correct practice should be to charge for gas before performing the work
Since we perform validation before other operations, it is not feasible to use a scaling gas multiplier. Instead, we can use a fixed gas cost (set as 1000000 to start with). This is currently roughly the amount we were going to be charging with the default 10x multiplier as well.
Testing performed to validate your change
Current unit and integration tests