From 49c105c85bb53ee8395a75dff3229bfb0b7e241b Mon Sep 17 00:00:00 2001 From: Achille Roussel Date: Fri, 14 Oct 2022 10:36:03 -0700 Subject: [PATCH 1/2] change writer retries stat from summary to counter --- writer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/writer.go b/writer.go index f95c76fff..0d001d68e 100644 --- a/writer.go +++ b/writer.go @@ -356,7 +356,7 @@ type WriterStats struct { BatchTime DurationStats `metric:"kafka.writer.batch.seconds"` WriteTime DurationStats `metric:"kafka.writer.write.seconds"` WaitTime DurationStats `metric:"kafka.writer.wait.seconds"` - Retries SummaryStats `metric:"kafka.writer.retries.count"` + Retries int64 `metric:"kafka.writer.retries.count"` BatchSize SummaryStats `metric:"kafka.writer.batch.size"` BatchBytes SummaryStats `metric:"kafka.writer.batch.bytes"` @@ -403,7 +403,7 @@ type writerStats struct { batchTime summary writeTime summary waitTime summary - retries summary + retries counter batchSize summary batchSizeBytes summary } From 408c4a21307528afa0d710f2b1bad04c8e4902ef Mon Sep 17 00:00:00 2001 From: Achille Roussel Date: Fri, 28 Oct 2022 09:45:03 -0700 Subject: [PATCH 2/2] set retries metric type to counter --- writer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/writer.go b/writer.go index 0d001d68e..47ee439a8 100644 --- a/writer.go +++ b/writer.go @@ -356,7 +356,7 @@ type WriterStats struct { BatchTime DurationStats `metric:"kafka.writer.batch.seconds"` WriteTime DurationStats `metric:"kafka.writer.write.seconds"` WaitTime DurationStats `metric:"kafka.writer.wait.seconds"` - Retries int64 `metric:"kafka.writer.retries.count"` + Retries int64 `metric:"kafka.writer.retries.count" type:"counter"` BatchSize SummaryStats `metric:"kafka.writer.batch.size"` BatchBytes SummaryStats `metric:"kafka.writer.batch.bytes"`