diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f7cda9abd8..47dc9747c2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,13 +17,13 @@ jobs: steps: # See nx recipe: https://nx.dev/recipes/ci/monorepo-ci-github-actions - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false fetch-depth: 0 # nx recipe - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' @@ -54,13 +54,13 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false fetch-depth: 0 # nx recipe - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' @@ -93,13 +93,13 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false fetch-depth: 0 # nx recipe - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' @@ -145,12 +145,12 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/ext.yml b/.github/workflows/ext.yml index db7cf5dfb7..df88550203 100644 --- a/.github/workflows/ext.yml +++ b/.github/workflows/ext.yml @@ -17,8 +17,8 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: yarn diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 263d604f41..7bf5d7ddc1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -23,12 +23,12 @@ jobs: node-version: [18.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: token: ${{ secrets.GH_PAT }} - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} registry-url: 'https://registry.npmjs.org' @@ -63,7 +63,7 @@ jobs: runs-on: ubuntu-20.04 timeout-minutes: 15 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 # Shallow clones should be disabled for computing changelog fetch-tags: true diff --git a/scripts/github-action/create-github-release.js b/scripts/github-action/create-github-release.js index db1503253c..275a0e3d42 100644 --- a/scripts/github-action/create-github-release.js +++ b/scripts/github-action/create-github-release.js @@ -143,7 +143,8 @@ async function getPRsBetweenCommits(github, context, core, lastCommit, currentCo return prsMerged.search.nodes.map((pr) => ({ number: `[#${pr.number}](${pr.url})`, - title: pr.title, + // escape the pipe character in the title to avoid table formatting issues + title: pr.title.replace('|', '\\|'), url: pr.url, files: pr.files.nodes.map((file) => file.path), author: `@${pr.author.login}`, @@ -200,7 +201,7 @@ function formatChangeLog(prs, tagsContext, context) { const changelog = ` # What's New - + https://github.com/${context.repo.owner}/${context.repo.repo}/compare/${releaseDiff} ## Packages Published @@ -208,7 +209,7 @@ function formatChangeLog(prs, tagsContext, context) { ${formattedPackageTags || 'No packages published'} ${internalPRS.length > 0 ? formatTable(internalPRS, tableConfig, '## Internal PRs') : ''} - + ${externalPRs.length > 0 ? formatTable(externalPRs, tableConfig, '## External PRs') : ''} ` // trim double spaces and return the changelog @@ -225,8 +226,9 @@ function formatTable(prs, tableConfig, title = '') { ${prs.map((pr) => `|${tableConfig.map((config) => pr[config.value]).join('|')}|`).join('\n')} ` } - -// Map PRs with affected destinations based on the files changed +/* + * Map PR with affected destinations + */ function mapPRWithAffectedDestinations(pr) { let affectedDestinations = [] if (pr.labels.includes('mode:cloud')) {