Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Add white list of consumer groups #4

Closed
seglo opened this issue Mar 11, 2019 · 5 comments
Closed

Add white list of consumer groups #4

seglo opened this issue Mar 11, 2019 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@seglo
Copy link
Owner

seglo commented Mar 11, 2019

Allow user to only report certain groups that match a list of regex.

@seglo seglo added the enhancement New feature or request label Apr 17, 2019
@seglo seglo added this to the 0.4.1 milestone Apr 17, 2019
@seglo seglo changed the title Add black list of consumer groups to Kafka Lag Exporter Add black list of consumer groups May 1, 2019
@seglo seglo modified the milestones: 0.4.1, 0.4.2 Jun 5, 2019
@seglo seglo changed the title Add black list of consumer groups Add white list of consumer groups Jun 15, 2019
@seglo
Copy link
Owner Author

seglo commented Jun 15, 2019

An array of RegEx patterns to match polled consumer group topic partitions against. If any of the patterns match then report that topics offsets.

When configuration is undefined or list is empty. Report all topics.

Use cases

Report all topics

whitelist = []

Report only topics with the suffix .xyzcorp-topics.

whitelist = [
  ".*\.xyzcorp-topics"
]

@seglo seglo added the good first issue Good for newcomers label Jun 15, 2019
@seglo seglo modified the milestones: 0.4.2, 0.4.4 Jun 20, 2019
@seglo seglo modified the milestones: 0.5.0, 0.5.1 Aug 14, 2019
@gholickar
Copy link

gholickar commented Aug 26, 2019

As discussed over email, I would like to have this feature implemented so we can filter consumer topic in our production environment that contains lot of Spark consumer topic names that are not interest to us. George

@seglo seglo modified the milestones: 0.5.1, 0.5.2 Sep 3, 2019
@graphex
Copy link
Contributor

graphex commented Sep 21, 2019

A blacklist in addition to the whitelist would also be useful for ignoring console consumers, for example. I might make another issue for black+whitelists for topic names, which tends to be useful when using kafka streams.

@seglo
Copy link
Owner Author

seglo commented Sep 21, 2019

That's true. I'm sort of on the fence vs white or black lists. Could a whitelist with a regex satisfy the use case you describe?

@seglo
Copy link
Owner Author

seglo commented Sep 22, 2019

@gholickar Hi George. I've implemented this in 0.5.2. Check it out and LMK!

@seglo seglo closed this as completed Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants