-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Weekly interval rules are sometimes calculated incorrectly #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacso
reviewed
Oct 21, 2021
❤️ thank you @pacso |
This looks correct @seejohnrun |
seejohnrun
approved these changes
Oct 25, 2021
Thank you! |
Of course, with the new checks this build now fails with a missing update to the changelog. Could you do the honours @jakebrady5? |
pacso
approved these changes
Oct 25, 2021
pacso
reviewed
Oct 25, 2021
pacso
reviewed
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec covers the context through which this bug was uncovered. Essentially generating
occurrences_between
for a relatively small date range was yielding false occurrences for weekly interval rules.I observed that
@time = @start_time if @time < @start_time
was set to happen only when@start_time
was falsey. Iterations past the first for a given rule inSchedule#next_time
here in situations similar to the spec would pass in atime
that was less thanstart_time
.Since
@start_time
was already defined in the rule, this@time
value would be passed long for validation.Most rules will then return immediately in this case, not applying their validation.
Any feedback is welcome!